chrome/common/service_process_util.cc - Issue 186473002: Deprecate named base::SharedMemory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/service_process_util.cc

Issue 186473002: Deprecate named base::SharedMemory. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix win Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/service_process_util.cc

diff --git a/chrome/common/service_process_util.cc b/chrome/common/service_process_util.cc

index d542b74e368cb2553c6ab2cb5ed8cc1a2231ed61..0b239a2b81570728cf020a528777ca32ca9f45fe 100644

--- a/chrome/common/service_process_util.cc

+++ b/chrome/common/service_process_util.cc

@@ -223,8 +223,9 @@ bool ServiceProcessState::CreateSharedData() {

return false;

uint32 alloc_size = sizeof(ServiceProcessSharedData);

- if (!shared_mem_service_data->CreateNamed(GetServiceProcessSharedMemName(),

- true, alloc_size))

+ // TODO(viettrungluu): Named shared memory is deprecated (crbug.com/345734).

+ if (!shared_mem_service_data->CreateNamedDeprecated

+ (GetServiceProcessSharedMemName(), true, alloc_size))

return false;

if (!shared_mem_service_data->Map(alloc_size))

« no previous file with comments | « base/metrics/stats_table.cc ('k') | content/child/resource_dispatcher_unittest.cc » ('j') | no next file with comments »