content/child/resource_dispatcher_unittest.cc - Issue 186473002: Deprecate named base::SharedMemory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/resource_dispatcher_unittest.cc

Issue 186473002: Deprecate named base::SharedMemory. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix win Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/child/resource_dispatcher_unittest.cc

diff --git a/content/child/resource_dispatcher_unittest.cc b/content/child/resource_dispatcher_unittest.cc

index 320564fbb23ce752be90d143220d576833b73700..5db4085636cc80e50bd85734c803b95a965a9204 100644

--- a/content/child/resource_dispatcher_unittest.cc

+++ b/content/child/resource_dispatcher_unittest.cc

@@ -307,7 +307,10 @@ class DeferredResourceLoadingTest : public ResourceDispatcherTest,

virtual void SetUp() OVERRIDE {

ResourceDispatcherTest::SetUp();

shared_handle_.Delete(kShmemSegmentName);

- EXPECT_TRUE(shared_handle_.CreateNamed(kShmemSegmentName, false, 100));

+ // TODO(viettrungluu): Named shared memory is deprecated (crbug.com/345734).

+ // (I don't think we even need it here.)

+ EXPECT_TRUE(shared_handle_.CreateNamedDeprecated(kShmemSegmentName, false,

+ 100));

}

virtual void TearDown() OVERRIDE {

« no previous file with comments | « chrome/common/service_process_util.cc ('k') | no next file » | no next file with comments »