Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1051)

Unified Diff: media/audio/audio_manager_base.h

Issue 1864483002: Forward output glitch information from stream WebRTC log (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/audio/audio_manager.h ('k') | media/audio/audio_manager_base.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/audio/audio_manager_base.h
diff --git a/media/audio/audio_manager_base.h b/media/audio/audio_manager_base.h
index 2a8c2d54ea915ffeccecbe7fae918ebe06eb57eb..c1349aadc14d4c2b57200641ebb3a0546adf5f52 100644
--- a/media/audio/audio_manager_base.h
+++ b/media/audio/audio_manager_base.h
@@ -38,9 +38,12 @@ class MEDIA_EXPORT AudioManagerBase : public AudioManager {
void GetAudioOutputDeviceNames(AudioDeviceNames* device_names) override;
AudioOutputStream* MakeAudioOutputStream(
const AudioParameters& params,
- const std::string& device_id) override;
- AudioInputStream* MakeAudioInputStream(const AudioParameters& params,
- const std::string& device_id) override;
+ const std::string& device_id,
+ const LogCallback& log_callback) override;
+ AudioInputStream* MakeAudioInputStream(
+ const AudioParameters& params,
+ const std::string& device_id,
+ const LogCallback& log_callback) override;
AudioOutputStream* MakeAudioOutputStreamProxy(
const AudioParameters& params,
const std::string& device_id) override;
@@ -68,21 +71,27 @@ class MEDIA_EXPORT AudioManagerBase : public AudioManager {
// Creates the output stream for the |AUDIO_PCM_LINEAR| format. The legacy
// name is also from |AUDIO_PCM_LINEAR|.
virtual AudioOutputStream* MakeLinearOutputStream(
- const AudioParameters& params) = 0;
+ const AudioParameters& params,
+ const LogCallback& log_callback) = 0;
// Creates the output stream for the |AUDIO_PCM_LOW_LATENCY| format.
virtual AudioOutputStream* MakeLowLatencyOutputStream(
const AudioParameters& params,
- const std::string& device_id) = 0;
+ const std::string& device_id,
+ const LogCallback& log_callback) = 0;
// Creates the input stream for the |AUDIO_PCM_LINEAR| format. The legacy
// name is also from |AUDIO_PCM_LINEAR|.
virtual AudioInputStream* MakeLinearInputStream(
- const AudioParameters& params, const std::string& device_id) = 0;
+ const AudioParameters& params,
+ const std::string& device_id,
+ const LogCallback& log_callback) = 0;
// Creates the input stream for the |AUDIO_PCM_LOW_LATENCY| format.
virtual AudioInputStream* MakeLowLatencyInputStream(
- const AudioParameters& params, const std::string& device_id) = 0;
+ const AudioParameters& params,
+ const std::string& device_id,
+ const LogCallback& log_callback) = 0;
// Get number of input or output streams.
int input_stream_count() const { return num_input_streams_; }
« no previous file with comments | « media/audio/audio_manager.h ('k') | media/audio/audio_manager_base.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698