Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(616)

Unified Diff: media/audio/audio_manager.h

Issue 1864483002: Forward output glitch information from stream WebRTC log (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/audio/audio_low_latency_input_output_unittest.cc ('k') | media/audio/audio_manager_base.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/audio/audio_manager.h
diff --git a/media/audio/audio_manager.h b/media/audio/audio_manager.h
index 90dba8ade735804682740ff57f852fe171e3c78c..27317c5c27d6909a992e61c432eca556fe1de2c0 100644
--- a/media/audio/audio_manager.h
+++ b/media/audio/audio_manager.h
@@ -8,6 +8,7 @@
#include <memory>
#include <string>
+#include "base/callback_forward.h"
#include "base/macros.h"
#include "base/memory/ref_counted.h"
#include "base/sequenced_task_runner_helpers.h"
@@ -132,6 +133,10 @@ class MEDIA_EXPORT AudioManager {
// Audio worker thread (see GetWorkerTaskRunner()).
virtual void GetAudioOutputDeviceNames(AudioDeviceNames* device_names) = 0;
+ // Log callback used for sending log messages from a stream to the object
+ // that manages the stream.
+ using LogCallback = base::Callback<void(const std::string&)>;
+
// Factory for all the supported stream formats. |params| defines parameters
// of the audio stream to be created.
//
@@ -155,7 +160,8 @@ class MEDIA_EXPORT AudioManager {
// Do not free the returned AudioOutputStream. It is owned by AudioManager.
virtual AudioOutputStream* MakeAudioOutputStream(
const AudioParameters& params,
- const std::string& device_id) = 0;
+ const std::string& device_id,
+ const LogCallback& log_callback) = 0;
// Creates new audio output proxy. A proxy implements
// AudioOutputStream interface, but unlike regular output stream
@@ -179,7 +185,8 @@ class MEDIA_EXPORT AudioManager {
// When you are done with it, call |Stop()| and |Close()| to release it.
virtual AudioInputStream* MakeAudioInputStream(
const AudioParameters& params,
- const std::string& device_id) = 0;
+ const std::string& device_id,
+ const LogCallback& log_callback) = 0;
// Returns the task runner used for audio IO.
// TODO(alokp): Rename to task_runner().
« no previous file with comments | « media/audio/audio_low_latency_input_output_unittest.cc ('k') | media/audio/audio_manager_base.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698