Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(911)

Unified Diff: media/audio/audio_manager_base.cc

Issue 1864483002: Forward output glitch information from stream WebRTC log (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/audio/audio_manager_base.h ('k') | media/audio/audio_output_dispatcher_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/audio/audio_manager_base.cc
diff --git a/media/audio/audio_manager_base.cc b/media/audio/audio_manager_base.cc
index 545d47d379e509a15c806a075c0419d7479fb00a..bfca277e7312dcf4bfafbe188d953659876009a8 100644
--- a/media/audio/audio_manager_base.cc
+++ b/media/audio/audio_manager_base.cc
@@ -105,7 +105,8 @@ base::string16 AudioManagerBase::GetAudioInputDeviceModel() {
AudioOutputStream* AudioManagerBase::MakeAudioOutputStream(
const AudioParameters& params,
- const std::string& device_id) {
+ const std::string& device_id,
+ const LogCallback& log_callback) {
DCHECK(GetTaskRunner()->BelongsToCurrentThread());
if (!params.IsValid()) {
@@ -130,10 +131,10 @@ AudioOutputStream* AudioManagerBase::MakeAudioOutputStream(
case AudioParameters::AUDIO_PCM_LINEAR:
DCHECK(AudioDeviceDescription::IsDefaultDevice(device_id))
<< "AUDIO_PCM_LINEAR supports only the default device.";
- stream = MakeLinearOutputStream(params);
+ stream = MakeLinearOutputStream(params, log_callback);
break;
case AudioParameters::AUDIO_PCM_LOW_LATENCY:
- stream = MakeLowLatencyOutputStream(params, device_id);
+ stream = MakeLowLatencyOutputStream(params, device_id, log_callback);
break;
case AudioParameters::AUDIO_FAKE:
stream = FakeAudioOutputStream::MakeFakeStream(this, params);
@@ -152,7 +153,8 @@ AudioOutputStream* AudioManagerBase::MakeAudioOutputStream(
AudioInputStream* AudioManagerBase::MakeAudioInputStream(
const AudioParameters& params,
- const std::string& device_id) {
+ const std::string& device_id,
+ const LogCallback& log_callback) {
DCHECK(GetTaskRunner()->BelongsToCurrentThread());
if (!params.IsValid() || (params.channels() > kMaxInputChannels) ||
@@ -174,10 +176,10 @@ AudioInputStream* AudioManagerBase::MakeAudioInputStream(
AudioInputStream* stream;
switch (params.format()) {
case AudioParameters::AUDIO_PCM_LINEAR:
- stream = MakeLinearInputStream(params, device_id);
+ stream = MakeLinearInputStream(params, device_id, log_callback);
break;
case AudioParameters::AUDIO_PCM_LOW_LATENCY:
- stream = MakeLowLatencyInputStream(params, device_id);
+ stream = MakeLowLatencyInputStream(params, device_id, log_callback);
break;
case AudioParameters::AUDIO_FAKE:
stream = FakeAudioInputStream::MakeFakeStream(this, params);
« no previous file with comments | « media/audio/audio_manager_base.h ('k') | media/audio/audio_output_dispatcher_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698