Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 186433003: Clean up generate_event_interfaces.py (Closed)

Created:
6 years, 9 months ago by Nils Barth (inactive)
Modified:
6 years, 9 months ago
Reviewers:
haraken
CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, sof, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, Inactive
Visibility:
Public.

Description

Clean up generate_event_interfaces.py Follow-up to the split CL. Just clean-up, no changes to generated EventInterfaces.in. * Rename to generate_event_interfaces (from "*_names") This is b/c: - the output file is called EventInterfaces.in - the output file is used for both EventFactory and EventNames * Remove EventInterfaces.in from run-bindings-tests This file is useless, and adds unnecessary complexity to r-b-t. The actual output file is trivial: namespace="Event" Source/bindings/tests/idls/TestInterfaceEventConstructor ...and I've never looked at it during CG changes. With it, we need to have 2 passes of compute_interfaces_info, and a separate temporary file. Without it, once Terry's CL lands, we'll have no individual files, and we can just use one temporary directory, removing lots of temp file complexity. * Compute source_dir robustly (not using getcwd) * Refactoring and renaming Follow-up to: Split generate_event_interfaces.py from compute_interfaces_info.py https://codereview.chromium.org/185303008/ BUG=341748 R=haraken Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168599

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -79 lines) Patch
M Source/bindings/generated_bindings.gyp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/scripts/generate_event_interfaces.py View 4 chunks +41 lines, -41 lines 0 comments Download
D Source/bindings/tests/results/EventInterfaces.in View 1 chunk +0 lines, -3 lines 0 comments Download
M Tools/Scripts/webkitpy/bindings/main.py View 6 chunks +11 lines, -34 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Nils Barth (inactive)
Follow-up clean-up.
6 years, 9 months ago (2014-03-04 07:12:38 UTC) #1
haraken
LGTM
6 years, 9 months ago (2014-03-04 08:37:59 UTC) #2
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 9 months ago (2014-03-06 01:01:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/186433003/1
6 years, 9 months ago (2014-03-06 01:01:59 UTC) #4
commit-bot: I haz the power
6 years, 9 months ago (2014-03-06 08:18:30 UTC) #5
Message was sent while issue was closed.
Change committed as 168599

Powered by Google App Engine
This is Rietveld 408576698