Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 185303008: Split generate_event_interfaces.py from compute_interfaces_info.py (Closed)

Created:
6 years, 9 months ago by Nils Barth (inactive)
Modified:
6 years, 9 months ago
Reviewers:
haraken
CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, sof, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, Inactive, terry, Nico
Visibility:
Public.

Description

Split generate_event_interfaces.py from compute_interfaces_info.py This is the last step in factoring compute_interfaces_info: EventInterfaces.in is a simple auxiliary file that's largely unrelated to bindings. Splitting it out means compute_interfaces_info now purely computes interfaces info! This means we can reuse it without needing dummy files (e.g., in r-b-t and in gyp), and also simplifies its code. We can actually simplify both scripts (and r-b-t) further, but this is a conservative CL, just splitting it out. BUG=341748 R=haraken Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168499

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+178 lines, -61 lines) Patch
M Source/bindings/generated_bindings.gyp View 3 chunks +31 lines, -4 lines 0 comments Download
M Source/bindings/scripts/compute_interfaces_info.py View 5 chunks +5 lines, -49 lines 0 comments Download
A Source/bindings/scripts/generate_event_interfaces.py View 1 chunk +130 lines, -0 lines 0 comments Download
M Tools/Scripts/webkitpy/bindings/main.py View 3 chunks +12 lines, -8 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Nils Barth (inactive)
Last step of factoring compute_interfaces_info. (Unlike the generate_global_constructors, this time I'm *starting* with the conservative, ...
6 years, 9 months ago (2014-03-03 05:51:31 UTC) #1
haraken
LGTM
6 years, 9 months ago (2014-03-03 06:05:49 UTC) #2
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 9 months ago (2014-03-03 23:45:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/185303008/1
6 years, 9 months ago (2014-03-03 23:46:11 UTC) #4
Nils Barth (inactive)
The CQ bit was unchecked by nbarth@chromium.org
6 years, 9 months ago (2014-03-04 08:51:25 UTC) #5
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 9 months ago (2014-03-04 08:51:33 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-04 15:27:20 UTC) #7
commit-bot: I haz the power
Retried try job too often on win_layout for step(s) webkit_lint http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout&number=25481
6 years, 9 months ago (2014-03-04 15:27:20 UTC) #8
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 9 months ago (2014-03-05 01:44:37 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/185303008/1
6 years, 9 months ago (2014-03-05 01:46:31 UTC) #10
Nils Barth (inactive)
The CQ bit was unchecked by nbarth@chromium.org
6 years, 9 months ago (2014-03-05 11:58:18 UTC) #11
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 9 months ago (2014-03-05 11:58:24 UTC) #12
commit-bot: I haz the power
6 years, 9 months ago (2014-03-05 17:53:47 UTC) #13
Message was sent while issue was closed.
Change committed as 168499

Powered by Google App Engine
This is Rietveld 408576698