Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1431)

Unified Diff: common/api/logdog_coordinator/services/v1/tasks.proto

Issue 1863973002: LogDog: Update to archival V2. (Closed) Base URL: https://github.com/luci/luci-go@grpcutil-errors
Patch Set: Minor fixes, works in dev now. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: common/api/logdog_coordinator/services/v1/tasks.proto
diff --git a/common/api/logdog_coordinator/services/v1/tasks.proto b/common/api/logdog_coordinator/services/v1/tasks.proto
index d208f61c5ae35038c641011b42e00361d355dc36..d7bfabed651ef166a779069027cf97fed42ec3e1 100644
--- a/common/api/logdog_coordinator/services/v1/tasks.proto
+++ b/common/api/logdog_coordinator/services/v1/tasks.proto
@@ -6,12 +6,19 @@ syntax = "proto3";
package logdog;
+import "google/protobuf/duration.proto";
+
// ArchiveTask is a task queue task description for the archival of a single
// log stream.
message ArchiveTask {
// The path of the log stream to archive.
string path = 1;
- // If true, require that the log stream be complete.
- bool complete = 2;
+ // The amount of time after the task was created that log stream completeness
+ // will be used as a success criteria. If the task's age is older than this
+ // value, completeness will not be enforced.
+ //
+ // The task's age can be calculated by subtracting its lease expiration time
+ // (leaseTimestamp) from its enqueued timestamp (enqueueTimestamp).
Vadim Sh. 2016/04/07 01:21:32 dunno, I'd just use global timestamp and don't bot
dnj 2016/04/11 17:20:04 Since we have to load the stream state in the Arch
+ google.protobuf.Duration complete_period = 2;
}

Powered by Google App Engine
This is Rietveld 408576698