common/api/logdog_coordinator/services/v1/tasks.proto - Issue 1863973002: LogDog: Update to archival V2.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: common/api/logdog_coordinator/services/v1/tasks.proto

Issue 1863973002: LogDog: Update to archival V2. (Closed) Base URL: https://github.com/luci/luci-go@grpcutil-errors

Patch Set: Minor fixes, works in dev now. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« common/api/logdog_coordinator/services/v1/service.proto ('K') | « common/api/logdog_coordinator/services/v1/service.pb.go ('k') | common/api/logdog_coordinator/services/v1/tasks.pb.go » ('j') | server/internal/logdog/archivist/archivist.go » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 syntax = "proto3";	5 syntax = "proto3";

6	6

7 package logdog;	7 package logdog;

8	8

	9 import "google/protobuf/duration.proto";

	10

9 // ArchiveTask is a task queue task description for the archival of a single	11 // ArchiveTask is a task queue task description for the archival of a single

10 // log stream.	12 // log stream.

11 message ArchiveTask {	13 message ArchiveTask {

12 // The path of the log stream to archive.	14 // The path of the log stream to archive.

13 string path = 1;	15 string path = 1;

14	16

15 // If true, require that the log stream be complete.	17 // The amount of time after the task was created that log stream completeness

16 bool complete = 2;	18 // will be used as a success criteria. If the task's age is older than this

	19 // value, completeness will not be enforced.

	20 //

	21 // The task's age can be calculated by subtracting its lease expiration time

	22 // (leaseTimestamp) from its enqueued timestamp (enqueueTimestamp).
	Vadim Sh. 2016/04/07 01:21:32 dunno, I'd just use global timestamp and don't bot dunno, I'd just use global timestamp and don't bother trying to calculate it from other fields if clocks are desyncronized, a lot of bad stuff happens anyway (e.g. SSL may stop to work). GCE machines are configured to use Google's NTP server by default, and will almost certainly by in sync with each other and with GAE clock. dnj 2016/04/11 17:20:04 Since we have to load the stream state in the Arch Show quoted text On 2016/04/07 01:21:32, Vadim Sh. wrote: > dunno, I'd just use global timestamp and don't bother trying to calculate it > from other fields > > if clocks are desyncronized, a lot of bad stuff happens anyway (e.g. SSL may > stop to work). GCE machines are configured to use Google's NTP server by > default, and will almost certainly by in sync with each other and with GAE > clock. Since we have to load the stream state in the Archivist anyway, I'm replacing this mechanism with just having the Coordinator supply the age as one of the results of that RPC. (But yes generically agree)
	23 google.protobuf.Duration complete_period = 2;

17 }	24 }

OLD	NEW