Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Unified Diff: common/api/logdog_coordinator/services/v1/service.proto

Issue 1863973002: LogDog: Update to archival V2. (Closed) Base URL: https://github.com/luci/luci-go@grpcutil-errors
Patch Set: Minor fixes, works in dev now. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: common/api/logdog_coordinator/services/v1/service.proto
diff --git a/common/api/logdog_coordinator/services/v1/service.proto b/common/api/logdog_coordinator/services/v1/service.proto
index db1ef88b07954b804fcf935ac7874548aea11f2e..c1aa4fb11feb573eb5efd88563b920d4bbaf2054 100644
--- a/common/api/logdog_coordinator/services/v1/service.proto
+++ b/common/api/logdog_coordinator/services/v1/service.proto
@@ -78,7 +78,7 @@ message TerminateStreamRequest {
// The log stream's secret.
bytes secret = 2;
- // The terminal index of the stream.
+ // The number of entries in the log stream.
Vadim Sh. 2016/04/07 01:21:32 in LogStreamState it is "index", here it is "numbe
dnj 2016/04/11 17:20:04 Sorry I was considering changing this, then revert
int64 terminal_index = 3;
}
@@ -87,11 +87,13 @@ message TerminateStreamRequest {
message ArchiveStreamRequest {
// The path of the log stream that was archived.
string path = 1;
- // If true, the archive includes the full set of log stream entries between
- // [0..terminal_index].
- bool complete = 2;
+ // The number of log entries that were archived.
+ int64 log_entry_count = 2;
// The highest log stream index that was archived.
int64 terminal_index = 3;
+ // If true, there was an archival error, and the referenced streams should be
+ // considered invalid.
+ bool error = 4;
Vadim Sh. 2016/04/07 01:21:32 maybe "string error" // if not empty, there was an
dnj 2016/04/11 17:20:04 I don't want to retain the error in datastore, so
// The archive URL of the log stream's stream data.
string stream_url = 10;

Powered by Google App Engine
This is Rietveld 408576698