LogDog: Update to archival V2.

common/api/logdog_coordinator/services/v1/service.proto

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 syntax = "proto3";
 
 package logdog;
 
 import "state.proto";
 import "github.com/luci/luci-go/common/proto/logdog/logpb/log.proto";
@@ skipping 60 matching lines @@
 }
 
 // TerminateStreamRequest is the set of caller-supplied data for the
 // TerminateStream service endpoint.
 message TerminateStreamRequest {
   // The log stream's path.
   string path = 1;
   // The log stream's secret.
   bytes secret = 2;
 
-  // The terminal index of the stream.
+  // The number of entries in the log stream.

[Vadim Sh., 2016/04/07 01:21:32]

in LogStreamState it is "index", here it is "number". What is it?

I mean in a list with 3 items, the terminal index is 2, but "number of entries"
is 3.

[dnj, 2016/04/11 17:20:04]

Sorry I was considering changing this, then reverted that decision, but I must
have forgotten to update the comment. Will fix.

   int64 terminal_index = 3;
 }
 
 // ArchiveStreamRequest is the set of caller-supplied data for the ArchiveStream
 // service endpoint.
 message ArchiveStreamRequest {
   // The path of the log stream that was archived.
   string path = 1;
-  // If true, the archive includes the full set of log stream entries between
-  // [0..terminal_index].
-  bool complete = 2;
+  // The number of log entries that were archived.
+  int64 log_entry_count = 2;
   // The highest log stream index that was archived.
   int64 terminal_index = 3;
+  // If true, there was an archival error, and the referenced streams should be
+  // considered invalid.
+  bool error = 4;

[Vadim Sh., 2016/04/07 01:21:32]

maybe "string error" // if not empty, there was an archival error...

to have some details about the error stored

[dnj, 2016/04/11 17:20:04]

I don't want to retain the error in datastore, so the only advantage this would
offer is to have the error be easily accessible in GAE logs. I suppose that's
worthwhile, though.

 
   // The archive URL of the log stream's stream data.
   string stream_url = 10;
   // The size of the log stream's stream data.
   int64 stream_size = 11;
 
   // The archive URL of the log stream's index data.
   string index_url = 20;
   // The size of the log stream's index data.
   int64 index_size = 21;
@@ skipping 19 matching lines @@
 
   // TerminateStream is an idempotent operation to update the stream's terminal
   // index.
   rpc TerminateStream(TerminateStreamRequest) returns (google.protobuf.Empty);
 
   // ArchiveStream is an idempotent operation to record a log stream's archival
   // parameters. It is used by the Archivist service upon successful stream
   // archival.
   rpc ArchiveStream(ArchiveStreamRequest) returns (google.protobuf.Empty);
 }