[keys] keep track of first and last non-empty prototype

[keys] keep track of the last non-empty prototype

Without the boundary prototypes we have to keep track of all shadowing properties
throughout the complete prototype chain. This contradicts the finding that most
objects have a rather large number of non-enumerable properties on the prototype
chain.

BUG=v8:705, v8:4905, v8:4706
Committed: https://crrev.com/991968029cc8452077a7f8e069a2eb7ce36fca49
Cr-Commit-Position: refs/heads/master@{#36776}

[Camillo Bruni, 2016-06-03 13:46:39]

Description was changed from

==========
[keys] keep track of first and last non-empty prototype

BUG=
==========

to

==========
[keys] keep track of first and last non-empty prototype

Without the boundary prototypes we have to keep track of all shadowing
properties
throughout the complete prototype chain. This contradicts the finding that most
objects have a rather large number of non-enumerable properties on the prototype
chain.

BUG=v8:705, v8:4905, v8:4706
==========

[Camillo Bruni, 2016-06-03 13:47:13]

cbruni@chromium.org changed reviewers:
+ jkummerow@chromium.org

[Camillo Bruni, 2016-06-03 13:47:13]

PTAL

[Jakob Kummerow, 2016-06-06 12:54:40]

lgtm

https://codereview.chromium.org/2038043002/diff/1/src/keys.cc
File src/keys.cc (right):

https://codereview.chromium.org/2038043002/diff/1/src/keys.cc#newcode434
src/keys.cc:434: filter_proxy_keys_, is_for_in_, *first_non_empty_prototype_,
any particular reason for the deref/rehandlify dance here?

[Camillo Bruni, 2016-06-06 14:04:27]

Description was changed from

==========
[keys] keep track of first and last non-empty prototype

Without the boundary prototypes we have to keep track of all shadowing
properties
throughout the complete prototype chain. This contradicts the finding that most
objects have a rather large number of non-enumerable properties on the prototype
chain.

BUG=v8:705, v8:4905, v8:4706
==========

to

==========
[keys] keep track of the last non-empty prototype

Without the boundary prototypes we have to keep track of all shadowing
properties
throughout the complete prototype chain. This contradicts the finding that most
objects have a rather large number of non-enumerable properties on the prototype
chain.

BUG=v8:705, v8:4905, v8:4706
==========

[Jakob Kummerow, 2016-06-06 14:11:48]

still LGTM

https://codereview.chromium.org/2038043002/diff/40001/src/keys.cc
File src/keys.cc (right):

https://codereview.chromium.org/2038043002/diff/40001/src/keys.cc#newcode227
src/keys.cc:227: has_empty_prototype_ &= false;
drop the '&', just '=', it's cleaner

[Camillo Bruni, 2016-06-06 14:14:53]

The CQ bit was checked by cbruni@chromium.org

[Camillo Bruni, 2016-06-06 14:14:53]

The patchset sent to the CQ was uploaded after l-g-t-m from
jkummerow@chromium.org
Link to the patchset: https://codereview.chromium.org/2038043002/#ps60001
(title: "addressing nit")

[commit-bot: I haz the power, 2016-06-06 14:14:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2038043002/60001

[commit-bot: I haz the power, 2016-06-06 14:26:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-06 14:26:29]

Try jobs failed on following builders:
  v8_linux_gcc_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)

[Camillo Bruni, 2016-06-07 08:20:49]

The CQ bit was checked by cbruni@chromium.org

[Camillo Bruni, 2016-06-07 08:20:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
jkummerow@chromium.org
Link to the patchset: https://codereview.chromium.org/2038043002/#ps100001
(title: "do not initialize handle with nullptr")

[commit-bot: I haz the power, 2016-06-07 08:20:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2038043002/100001

[commit-bot: I haz the power, 2016-06-07 08:50:14]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-06-07 08:51:47]

Description was changed from

==========
[keys] keep track of the last non-empty prototype

Without the boundary prototypes we have to keep track of all shadowing
properties
throughout the complete prototype chain. This contradicts the finding that most
objects have a rather large number of non-enumerable properties on the prototype
chain.

BUG=v8:705, v8:4905, v8:4706
==========

to

==========
[keys] keep track of the last non-empty prototype

Without the boundary prototypes we have to keep track of all shadowing
properties
throughout the complete prototype chain. This contradicts the finding that most
objects have a rather large number of non-enumerable properties on the prototype
chain.

BUG=v8:705, v8:4905, v8:4706

Committed: https://crrev.com/991968029cc8452077a7f8e069a2eb7ce36fca49
Cr-Commit-Position: refs/heads/master@{#36776}
==========

[commit-bot: I haz the power, 2016-06-07 08:51:48]

Patchset 6 (id:??) landed as
https://crrev.com/991968029cc8452077a7f8e069a2eb7ce36fca49
Cr-Commit-Position: refs/heads/master@{#36776}