Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2038043002: [keys] keep track of first and last non-empty prototype (Closed)

Created:
4 years, 6 months ago by Camillo Bruni
Modified:
4 years, 6 months ago
Reviewers:
Jakob Kummerow
CC:
caitp (gmail), v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[keys] keep track of the last non-empty prototype Without the boundary prototypes we have to keep track of all shadowing properties throughout the complete prototype chain. This contradicts the finding that most objects have a rather large number of non-enumerable properties on the prototype chain. BUG=v8:705, v8:4905, v8:4706 Committed: https://crrev.com/991968029cc8452077a7f8e069a2eb7ce36fca49 Cr-Commit-Position: refs/heads/master@{#36776}

Patch Set 1 #

Total comments: 1

Patch Set 2 : cleanup #

Patch Set 3 : unskipping tests #

Total comments: 1

Patch Set 4 : addressing nit #

Patch Set 5 : fix var init #

Patch Set 6 : do not initialize handle with nullptr #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -29 lines) Patch
M src/keys.h View 1 4 chunks +6 lines, -0 lines 0 comments Download
M src/keys.cc View 1 2 3 4 10 chunks +41 lines, -29 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 17 (9 generated)
Camillo Bruni
PTAL
4 years, 6 months ago (2016-06-03 13:47:13 UTC) #3
Jakob Kummerow
lgtm https://codereview.chromium.org/2038043002/diff/1/src/keys.cc File src/keys.cc (right): https://codereview.chromium.org/2038043002/diff/1/src/keys.cc#newcode434 src/keys.cc:434: filter_proxy_keys_, is_for_in_, *first_non_empty_prototype_, any particular reason for the ...
4 years, 6 months ago (2016-06-06 12:54:40 UTC) #4
Jakob Kummerow
still LGTM https://codereview.chromium.org/2038043002/diff/40001/src/keys.cc File src/keys.cc (right): https://codereview.chromium.org/2038043002/diff/40001/src/keys.cc#newcode227 src/keys.cc:227: has_empty_prototype_ &= false; drop the '&', just ...
4 years, 6 months ago (2016-06-06 14:11:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2038043002/60001
4 years, 6 months ago (2016-06-06 14:14:56 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_gcc_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/builds/17195)
4 years, 6 months ago (2016-06-06 14:26:29 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2038043002/100001
4 years, 6 months ago (2016-06-07 08:20:59 UTC) #14
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 6 months ago (2016-06-07 08:50:14 UTC) #15
commit-bot: I haz the power
4 years, 6 months ago (2016-06-07 08:51:48 UTC) #17
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/991968029cc8452077a7f8e069a2eb7ce36fca49
Cr-Commit-Position: refs/heads/master@{#36776}

Powered by Google App Engine
This is Rietveld 408576698