Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 1836633002: x86 validator: Implement rewriting "movntq" to "movq" on x86-64 (Closed)

Created:
4 years, 9 months ago by Mark Seaborn
Modified:
4 years, 9 months ago
Reviewers:
Petr Hosek
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/src/native_client.git@master
Target Ref:
refs/heads/master
Project:
nacl
Visibility:
Public.

Description

x86 validator: Implement rewriting "movntq" to "movq" on x86-64 We were already doing this rewrite for x86-32. We had previously checked the Web Store to find all the non-temporal instructions that we need to handle and rewrite, but it looks like we missed at least one -- "movntq" is being used. The use might have appeared after we did the check. BUG= https://bugs.chromium.org/p/chromium/issues/detail?id=598085 TEST=run_validation_rewrite_test run_rewrite_nontemporals_test run_validation_cache_test Committed: https://chromium.googlesource.com/native_client/src/native_client/+/fb2c685d12b5a13cdb5b284b0ee1ee3c2080a769

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -4 lines) Patch
M src/trusted/validator/validation_rewrite_test.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M src/trusted/validator/validation_rewrite_test_data.S View 1 chunk +10 lines, -0 lines 0 comments Download
M src/trusted/validator_ragel/dfa_validate_common.c View 1 chunk +4 lines, -0 lines 0 comments Download
M tests/validator/rewrite_nontemporals.c View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Mark Seaborn
4 years, 9 months ago (2016-03-25 22:34:29 UTC) #3
Petr Hosek
lgtm
4 years, 9 months ago (2016-03-25 22:37:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1836633002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1836633002/1
4 years, 9 months ago (2016-03-25 22:41:45 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-25 23:09:07 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/native_client/src/native_client/+/fb2c685d1...

Powered by Google App Engine
This is Rietveld 408576698