Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1862993002: [arm] Implement Float(32|64)(Min|Max) using vsel. (Closed)

Created:
4 years, 8 months ago by jbramley
Modified:
4 years, 8 months ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[arm] Implement Float(32|64)(Min|Max) using vsel. BUG= Committed: https://crrev.com/141324cfdca27d199597d280c19943f9e7a4dbfa Cr-Commit-Position: refs/heads/master@{#35292}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+496 lines, -13 lines) Patch
M src/arm/assembler-arm.h View 1 chunk +11 lines, -0 lines 0 comments Download
M src/arm/assembler-arm.cc View 1 chunk +63 lines, -0 lines 0 comments Download
M src/arm/disasm-arm.cc View 1 chunk +42 lines, -0 lines 0 comments Download
M src/arm/simulator-arm.cc View 1 chunk +39 lines, -0 lines 0 comments Download
M src/compiler/arm/code-generator-arm.cc View 1 chunk +40 lines, -0 lines 0 comments Download
M src/compiler/arm/instruction-codes-arm.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/arm/instruction-scheduler-arm.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/arm/instruction-selector-arm.cc View 2 chunks +24 lines, -13 lines 0 comments Download
M test/cctest/test-assembler-arm.cc View 1 chunk +152 lines, -0 lines 0 comments Download
M test/cctest/test-disasm-arm.cc View 1 chunk +45 lines, -0 lines 0 comments Download
M test/unittests/compiler/arm/instruction-selector-arm-unittest.cc View 1 chunk +72 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
jbramley
This is like https://codereview.chromium.org/1360603003, but for ARM.
4 years, 8 months ago (2016-04-06 09:46:36 UTC) #2
Benedikt Meurer
Very nice, LGTM!
4 years, 8 months ago (2016-04-06 09:56:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1862993002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1862993002/1
4 years, 8 months ago (2016-04-06 09:58:16 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-06 10:17:18 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-06 10:18:05 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/141324cfdca27d199597d280c19943f9e7a4dbfa
Cr-Commit-Position: refs/heads/master@{#35292}

Powered by Google App Engine
This is Rietveld 408576698