third_party/WebKit/Source/platform/graphics/filters/FEOffset.cpp - Issue 1862733002: Remove all use of crop edges from SkImageFilter::CropRect.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/filters/FEOffset.cpp

Issue 1862733002: Remove all use of crop edges from SkImageFilter::CropRect. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix FEMorphology bug Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/graphics/filters/FEBlend.cpp ('K') | « third_party/WebKit/Source/platform/graphics/filters/FEMorphology.cpp ('k') | third_party/WebKit/Source/platform/graphics/filters/FETurbulence.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/filters/FEOffset.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/filters/FEOffset.cpp b/third_party/WebKit/Source/platform/graphics/filters/FEOffset.cpp

index a9ceb346d26bf32cbc42739272a415c498d21a9a..5f8417d9a359107f5f88688e2ec5e55a13590f34 100644

--- a/third_party/WebKit/Source/platform/graphics/filters/FEOffset.cpp

+++ b/third_party/WebKit/Source/platform/graphics/filters/FEOffset.cpp

@@ -77,8 +77,8 @@ PassRefPtr<SkImageFilter> FEOffset::createImageFilter(SkiaImageFilterBuilder& bu

{

RefPtr<SkImageFilter> input(builder.build(inputEffect(0), operatingColorSpace()));

Filter* filter = this->getFilter();

- SkImageFilter::CropRect cropRect = getCropRect();

- return adoptRef(SkOffsetImageFilter::Create(SkFloatToScalar(filter->applyHorizontalScale(m_dx)), SkFloatToScalar(filter->applyVerticalScale(m_dy)), input.get(), &cropRect));

+ SkImageFilter::CropRect cropRect;

+ return adoptRef(SkOffsetImageFilter::Create(SkFloatToScalar(filter->applyHorizontalScale(m_dx)), SkFloatToScalar(filter->applyVerticalScale(m_dy)), input.get(), getCropRect(&cropRect)));

}

TextStream& FEOffset::externalRepresentation(TextStream& ts, int indent) const