third_party/WebKit/Source/platform/graphics/filters/FEMorphology.cpp - Issue 1862733002: Remove all use of crop edges from SkImageFilter::CropRect.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/filters/FEMorphology.cpp

Issue 1862733002: Remove all use of crop edges from SkImageFilter::CropRect. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix FEMorphology bug Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/graphics/filters/FEBlend.cpp ('K') | « third_party/WebKit/Source/platform/graphics/filters/FEMerge.cpp ('k') | third_party/WebKit/Source/platform/graphics/filters/FEOffset.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/filters/FEMorphology.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/filters/FEMorphology.cpp b/third_party/WebKit/Source/platform/graphics/filters/FEMorphology.cpp

index 2f3bfcd4d5909d5e3975fc65d3d6b945f05b7819..c4e27c7fb4e4c406779822c596233e1404bd6396 100644

--- a/third_party/WebKit/Source/platform/graphics/filters/FEMorphology.cpp

+++ b/third_party/WebKit/Source/platform/graphics/filters/FEMorphology.cpp

@@ -98,10 +98,10 @@ PassRefPtr<SkImageFilter> FEMorphology::createImageFilter(SkiaImageFilterBuilder

RefPtr<SkImageFilter> input(builder.build(inputEffect(0), operatingColorSpace()));

SkScalar radiusX = SkFloatToScalar(getFilter()->applyHorizontalScale(m_radiusX));

SkScalar radiusY = SkFloatToScalar(getFilter()->applyVerticalScale(m_radiusY));

- SkImageFilter::CropRect rect = getCropRect();

+ SkImageFilter::CropRect rect;

if (m_type == FEMORPHOLOGY_OPERATOR_DILATE)

- return adoptRef(SkDilateImageFilter::Create(radiusX, radiusY, input.get(), &rect));

- return adoptRef(SkErodeImageFilter::Create(radiusX, radiusY, input.get(), &rect));

+ return adoptRef(SkDilateImageFilter::Create(radiusX, radiusY, input.get(), getCropRect(&rect)));

+ return adoptRef(SkErodeImageFilter::Create(radiusX, radiusY, input.get(), getCropRect(&rect)));

}

static TextStream& operator<<(TextStream& ts, const MorphologyOperatorType& type)