third_party/WebKit/Source/platform/graphics/filters/FEBlend.cpp - Issue 1862733002: Remove all use of crop edges from SkImageFilter::CropRect.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/filters/FEBlend.cpp

Issue 1862733002: Remove all use of crop edges from SkImageFilter::CropRect. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix FEMorphology bug Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.cpp ('K') | « third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.cpp ('k') | third_party/WebKit/Source/platform/graphics/filters/FEColorMatrix.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/filters/FEBlend.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/filters/FEBlend.cpp b/third_party/WebKit/Source/platform/graphics/filters/FEBlend.cpp

index 7561b29e1bd39a81e5d84fdb19e5d5f7925a3d70..210a23eaa1e15d642c720bf34402b879b6064729 100644

--- a/third_party/WebKit/Source/platform/graphics/filters/FEBlend.cpp

+++ b/third_party/WebKit/Source/platform/graphics/filters/FEBlend.cpp

@@ -60,8 +60,8 @@ PassRefPtr<SkImageFilter> FEBlend::createImageFilter(SkiaImageFilterBuilder& bui

RefPtr<SkImageFilter> foreground(builder.build(inputEffect(0), operatingColorSpace()));

RefPtr<SkImageFilter> background(builder.build(inputEffect(1), operatingColorSpace()));

sk_sp<SkXfermode> mode(SkXfermode::Make(WebCoreCompositeToSkiaComposite(CompositeSourceOver, m_mode)));

- SkImageFilter::CropRect cropRect = getCropRect();

- return fromSkSp(SkXfermodeImageFilter::Make(std::move(mode), background.get(), foreground.get(), &cropRect));

+ SkImageFilter::CropRect cropRect;

+ return fromSkSp(SkXfermodeImageFilter::Make(std::move(mode), background.get(), foreground.get(), getCropRect(&cropRect)));

f(malita) 2016/04/06 14:21:08 Would it look cleaner to use a RAII helper and enc

Stephen White 2016/04/11 21:30:22 Thanks. Actually I think I'm going to rework this

}

TextStream& FEBlend::externalRepresentation(TextStream& ts, int indent) const