Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(821)

Unified Diff: third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.cpp

Issue 1862733002: Remove all use of crop edges from SkImageFilter::CropRect. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix FEMorphology bug Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.cpp
diff --git a/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.cpp b/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.cpp
index 3bc0a9850e0bf629b26017a2e0610ad5a2d00366..af8bbf036e7934b205e471235d71661f5729eda9 100644
--- a/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.cpp
+++ b/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.cpp
@@ -329,6 +329,9 @@ SkImageFilter* CanvasRenderingContext2DState::getFilter(Element* styleResolution
SkiaImageFilterBuilder imageFilterBuilder;
RawPtr<FilterEffect> lastEffect = filterEffectBuilder->lastEffect();
+ if (lastEffect) {
+ lastEffect->determineFilterPrimitiveSubregion();
f(malita) 2016/04/06 14:21:08 Is this something that could be pushed into Filter
Stephen White 2016/04/11 21:30:22 Unfortunately, each of the paths (HTML and SVG) is
f(malita) 2016/04/12 05:00:18 Ack.
+ }
m_resolvedFilter = imageFilterBuilder.build(lastEffect.get(), ColorSpaceDeviceRGB);
if (m_resolvedFilter) {
updateFilterReferences(toHTMLCanvasElement(styleResolutionHost), context, filterStyle->filter());

Powered by Google App Engine
This is Rietveld 408576698