Remove all use of crop edges from SkImageFilter::CropRect.

third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "modules/canvas2d/CanvasRenderingContext2DState.h"
 
 #include "core/css/CSSFontSelector.h"
 #include "core/css/resolver/FilterOperationResolver.h"
 #include "core/css/resolver/StyleBuilder.h"
 #include "core/css/resolver/StyleResolverState.h"
@@ skipping 311 matching lines @@
         m_fillStyle->applyToPaint(fillPaintForFilter);
         m_strokeStyle->applyToPaint(strokePaintForFilter);
         fillPaintForFilter.setColor(m_fillStyle->paintColor());
         strokePaintForFilter.setColor(m_strokeStyle->paintColor());
         FloatSize floatCanvasSize(canvasSize);
         const double effectiveZoom = 1.0; // Deliberately ignore zoom on the canvas element
         filterEffectBuilder->build(styleResolutionHost, filterStyle->filter(), effectiveZoom, &floatCanvasSize, &fillPaintForFilter, &strokePaintForFilter);
 
         SkiaImageFilterBuilder imageFilterBuilder;
         RawPtr<FilterEffect> lastEffect = filterEffectBuilder->lastEffect();
+        if (lastEffect) {
+            lastEffect->determineFilterPrimitiveSubregion();

[f(malita), 2016/04/06 14:21:08]

Is this something that could be pushed into FilterEffectBuilder::build()?

[Stephen White, 2016/04/11 21:30:22]

Unfortunately, each of the paths (HTML and SVG) is already calling this from a
different place. And I'd rather not mess with them just yet.

[f(malita), 2016/04/12 05:00:18]

Ack.

+        }
         m_resolvedFilter = imageFilterBuilder.build(lastEffect.get(), ColorSpaceDeviceRGB);
         if (m_resolvedFilter) {
             updateFilterReferences(toHTMLCanvasElement(styleResolutionHost), context, filterStyle->filter());
             if (lastEffect->originTainted())
                 context->setOriginTainted();
         }
     }
 
     return m_resolvedFilter.get();
 }
@@ skipping 223 matching lines @@
         paint->setLooper(0);
         paint->setImageFilter(shadowAndForegroundImageFilter());
         return paint;
     }
     paint->setLooper(sk_ref_sp(shadowAndForegroundDrawLooper()));
     paint->setImageFilter(0);
     return paint;
 }
 
 } // namespace blink