Change dialog texts for folder upload to explicitly indicate it's for 'Uploading'

Change dialog texts for folder upload to explicitly indicate it's for 'Uploading'

Currently we show the same dialog title and confirm button
('Select Folder' and 'OK' or 'Open') for folder upload,
but it should more clearly tell that it's for 'uploading',
so that the user can know s/he is exposing the folder
content to the website.

This patch makes following UI string changes to make it clear:

* "Select a folder to upload" for dialog title on ChromeOS
(original text is: "Select a folder to open")
* "Select Folder to Upload" for dialog title on other platforms
(original text is: "Select Folder")
* "Upload" for dialog confirm button (original text is: "Open")

The new string texts have gotten LGTM by UI team.

BUG=252888
TEST=manual
R=avi@chromium.org, jamesr@chromium.org, sky@chromium.org, yoshiki@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=214588

[kinuko, 2013-07-29 06:55:03]

I'm changing folder picker dialog texts for "<input type=file directory>" to
reduce the security concern. Can you review?

jamesr: content/renderer/render_view_impl.cc
avi: content/public/common/file_chooser_params.h

[Avi (use Gerrit), 2013-07-29 07:01:46]

BTW, can you cc me on the bug?

https://codereview.chromium.org/18627002/diff/1/ui/shell_dialogs/select_file_...
File ui/shell_dialogs/select_file_dialog.h (right):

https://codereview.chromium.org/18627002/diff/1/ui/shell_dialogs/select_file_...
ui/shell_dialogs/select_file_dialog.h:35: SELECT_UPLOAD_FOLDER,
Can you put comments about the difference between these? file_chooser_params.h
has Open/OpenMultiple/UploadFolder/Save, and explains the difference. This
almost mirrors that, but what's the difference, say, between SELECT_FOLDER and
SELECT_UPLOAD_FOLDER?

[kinuko, 2013-07-29 07:23:08]

Cc-ed both of you to the issue.

https://codereview.chromium.org/18627002/diff/1/ui/shell_dialogs/select_file_...
File ui/shell_dialogs/select_file_dialog.h (right):

https://codereview.chromium.org/18627002/diff/1/ui/shell_dialogs/select_file_...
ui/shell_dialogs/select_file_dialog.h:35: SELECT_UPLOAD_FOLDER,
On 2013/07/29 07:01:46, Avi wrote:
> Can you put comments about the difference between these? file_chooser_params.h
> has Open/OpenMultiple/UploadFolder/Save, and explains the difference. This
> almost mirrors that, but what's the difference, say, between SELECT_FOLDER and
> SELECT_UPLOAD_FOLDER?

Done.

This patch is trying to be minimal (to fix the security concern first), but
maybe in a follow-up CL I can also change SELECT_FOLDER to SELECT_OPEN_FOLDER,
and/or add a similar type for FILE too (i.e. SELECT_UPLOAD_FILE) to make this
change more complete.

[jamesr, 2013-07-29 09:01:13]

content/renderer/render_view_impl.cc lgtm

[kinuko, 2013-07-29 10:43:38]

sky: can you review ui/*, chrome/browser/ui/* changes?

[Avi (use Gerrit), 2013-07-29 14:44:48]

lgtm

https://codereview.chromium.org/18627002/diff/23001/ui/shell_dialogs/select_f...
File ui/shell_dialogs/select_file_dialog.h (right):

https://codereview.chromium.org/18627002/diff/23001/ui/shell_dialogs/select_f...
ui/shell_dialogs/select_file_dialog.h:38: // Like SELECT_FOLDER, but
specifically for uploading a folder.
Perhaps a comment that there is no functional difference from SELECT_FOLDER but
that it has explicit UI saying "upload"?

[sky, 2013-07-29 16:22:34]

LGTM

https://codereview.chromium.org/18627002/diff/23001/ui/shell_dialogs/gtk/sele...
File ui/shell_dialogs/gtk/select_file_dialog_impl_gtk.cc (right):

https://codereview.chromium.org/18627002/diff/23001/ui/shell_dialogs/gtk/sele...
ui/shell_dialogs/gtk/select_file_dialog_impl_gtk.cc:79: Type type, const
std::string& title,
nit: when you wrap, one param per line.

[kinuko, 2013-07-30 07:37:15]

https://codereview.chromium.org/18627002/diff/23001/ui/shell_dialogs/gtk/sele...
File ui/shell_dialogs/gtk/select_file_dialog_impl_gtk.cc (right):

https://codereview.chromium.org/18627002/diff/23001/ui/shell_dialogs/gtk/sele...
ui/shell_dialogs/gtk/select_file_dialog_impl_gtk.cc:79: Type type, const
std::string& title,
On 2013/07/29 16:22:34, sky wrote:
> nit: when you wrap, one param per line.

Done.

https://codereview.chromium.org/18627002/diff/23001/ui/shell_dialogs/select_f...
File ui/shell_dialogs/select_file_dialog.h (right):

https://codereview.chromium.org/18627002/diff/23001/ui/shell_dialogs/select_f...
ui/shell_dialogs/select_file_dialog.h:38: // Like SELECT_FOLDER, but
specifically for uploading a folder.
On 2013/07/29 14:44:49, Avi wrote:
> Perhaps a comment that there is no functional difference from SELECT_FOLDER
but
> that it has explicit UI saying "upload"?

Done.

[kinuko, 2013-07-30 07:38:46]

yoshiki: can you review c/b/*/file_manager/* UI changes?

[yoshiki, 2013-07-30 07:46:53]

lgtm. Thanks for doing this!

[kinuko, 2013-07-31 06:33:58]

Committed patchset #5 manually as r214588 (presubmit successful).