Change dialog texts for folder upload to explicitly indicate it's for 'Uploading'

ui/shell_dialogs/select_file_dialog.h

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_SHELL_DIALOGS_SELECT_FILE_DIALOG_H_
 #define UI_SHELL_DIALOGS_SELECT_FILE_DIALOG_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 14 matching lines @@
 class ShellDialogsDelegate;
 
 // Shows a dialog box for selecting a file or a folder.
 class SHELL_DIALOGS_EXPORT SelectFileDialog
     : public base::RefCountedThreadSafe<SelectFileDialog>,
       public BaseShellDialog {
  public:
   enum Type {
     SELECT_NONE,
     SELECT_FOLDER,
+    SELECT_UPLOAD_FOLDER,

[Avi (use Gerrit), 2013/07/29 07:01:46]

Can you put comments about the difference between these? file_chooser_params.h
has Open/OpenMultiple/UploadFolder/Save, and explains the difference. This
almost mirrors that, but what's the difference, say, between SELECT_FOLDER and
SELECT_UPLOAD_FOLDER?

[kinuko, 2013/07/29 07:23:08]

Done.

This patch is trying to be minimal (to fix the security concern first), but
maybe in a follow-up CL I can also change SELECT_FOLDER to SELECT_OPEN_FOLDER,
and/or add a similar type for FILE too (i.e. SELECT_UPLOAD_FILE) to make this
change more complete.

     SELECT_SAVEAS_FILE,
     SELECT_OPEN_FILE,
     SELECT_OPEN_MULTI_FILE
   };
 
   // An interface implemented by a Listener object wishing to know about the
   // the result of the Select File/Folder action. These callbacks must be
   // re-entrant.
   class SHELL_DIALOGS_EXPORT Listener {
    public:
@@ skipping 153 matching lines @@
   virtual bool HasMultipleFileTypeChoicesImpl() = 0;
 
   scoped_ptr<SelectFilePolicy> select_file_policy_;
 
   DISALLOW_COPY_AND_ASSIGN(SelectFileDialog);
 };
 
 }  // namespace ui
 
 #endif  // UI_SHELL_DIALOGS_SELECT_FILE_DIALOG_H_