chrome/browser/chromeos/extensions/file_manager/file_manager_util.cc - Issue 18627002: Change dialog texts for folder upload to explicitly indicate it's for 'Uploading'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/extensions/file_manager/file_manager_util.cc

Issue 18627002: Change dialog texts for folder upload to explicitly indicate it's for 'Uploading' (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: build fix Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/extensions/file_manager/file_browser_private_api.cc ('k') | chrome/browser/file_select_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/extensions/file_manager/file_manager_util.cc

diff --git a/chrome/browser/chromeos/extensions/file_manager/file_manager_util.cc b/chrome/browser/chromeos/extensions/file_manager/file_manager_util.cc

index c698bfcf05cd50bdc1323702eb65be248755933b..b500ebdc7e3e7dcc5d44922d58168f6ddf067a29 100644

--- a/chrome/browser/chromeos/extensions/file_manager/file_manager_util.cc

+++ b/chrome/browser/chromeos/extensions/file_manager/file_manager_util.cc

@@ -179,6 +179,10 @@ std::string GetDialogTypeAsString(

type_str = "folder";

break;

+ case ui::SelectFileDialog::SELECT_UPLOAD_FOLDER:

+ type_str = "upload-folder";

+ break;

case ui::SelectFileDialog::SELECT_SAVEAS_FILE:

type_str = "saveas-file";

break;

@@ -652,6 +656,11 @@ string16 GetTitleFromType(ui::SelectFileDialog::Type dialog_type) {

IDS_FILE_BROWSER_SELECT_FOLDER_TITLE);

break;

+ case ui::SelectFileDialog::SELECT_UPLOAD_FOLDER:

+ title = l10n_util::GetStringUTF16(

+ IDS_FILE_BROWSER_SELECT_UPLOAD_FOLDER_TITLE);

+ break;

case ui::SelectFileDialog::SELECT_SAVEAS_FILE:

title = l10n_util::GetStringUTF16(

IDS_FILE_BROWSER_SELECT_SAVEAS_FILE_TITLE);