Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 186153002: TaskManager: Remove some unused/unnecessary methods. (Closed)

Created:
6 years, 9 months ago by ncarter (slow)
Modified:
6 years, 9 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

TaskManager: Remove some unused/unnecessary methods. What's removed: - The idea of unique_id's (these were for the now-gone webUI taskmanager). - The GetResourceExtension() method, which the tests no longer need. - The IsBackground getter, which is not used. BUG=348836 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255217

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -98 lines) Patch
M chrome/browser/task_manager/background_resource_provider.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/task_manager/extension_process_resource_provider.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/task_manager/guest_resource_provider.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/task_manager/panel_resource_provider.cc View 3 chunks +4 lines, -10 lines 0 comments Download
M chrome/browser/task_manager/resource_provider.h View 3 chunks +1 line, -15 lines 0 comments Download
M chrome/browser/task_manager/resource_provider.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M chrome/browser/task_manager/tab_contents_resource_provider.cc View 2 chunks +0 lines, -11 lines 0 comments Download
M chrome/browser/task_manager/task_manager.h View 4 chunks +0 lines, -14 lines 0 comments Download
M chrome/browser/task_manager/task_manager.cc View 5 chunks +1 line, -27 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
ncarter (slow)
Hi Avi, Please have a look (this is the second in the series, and depends ...
6 years, 9 months ago (2014-03-03 22:05:13 UTC) #1
Avi (use Gerrit)
This looks good, but requires a bug #. Add in the same tracking bug # ...
6 years, 9 months ago (2014-03-03 22:55:03 UTC) #2
ncarter (slow)
yoshiki@chromium.org: Please review everything (as task_manager OWNER)
6 years, 9 months ago (2014-03-04 01:54:42 UTC) #3
Avi (use Gerrit)
FWIW it LGTM.
6 years, 9 months ago (2014-03-04 02:11:59 UTC) #4
yoshiki
task manager lgtm. Thanks for doing this.
6 years, 9 months ago (2014-03-05 18:34:13 UTC) #5
ncarter (slow)
The CQ bit was checked by nick@chromium.org
6 years, 9 months ago (2014-03-05 19:46:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nick@chromium.org/186153002/1
6 years, 9 months ago (2014-03-05 19:48:01 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-05 20:21:57 UTC) #8
commit-bot: I haz the power
Retried try job too often on win for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number=155965
6 years, 9 months ago (2014-03-05 20:21:57 UTC) #9
ncarter (slow)
The CQ bit was checked by nick@chromium.org
6 years, 9 months ago (2014-03-05 20:25:21 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nick@chromium.org/186153002/1
6 years, 9 months ago (2014-03-05 20:26:57 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-05 22:40:34 UTC) #12
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=275686
6 years, 9 months ago (2014-03-05 22:40:35 UTC) #13
ncarter (slow)
The CQ bit was checked by nick@chromium.org
6 years, 9 months ago (2014-03-05 22:46:53 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nick@chromium.org/186153002/1
6 years, 9 months ago (2014-03-05 22:48:45 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nick@chromium.org/186153002/1
6 years, 9 months ago (2014-03-06 00:08:13 UTC) #16
commit-bot: I haz the power
6 years, 9 months ago (2014-03-06 01:59:05 UTC) #17
Message was sent while issue was closed.
Change committed as 255217

Powered by Google App Engine
This is Rietveld 408576698