Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4185)

Unified Diff: chrome/browser/task_manager/task_manager.cc

Issue 186153002: TaskManager: Remove some unused/unnecessary methods. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/task_manager/task_manager.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/task_manager/task_manager.cc
diff --git a/chrome/browser/task_manager/task_manager.cc b/chrome/browser/task_manager/task_manager.cc
index 7969f36bad14627d3491ce42ef0f71e6db8ef24d..e876bcf9237ea4137a0af09c459f685d470939ab 100644
--- a/chrome/browser/task_manager/task_manager.cc
+++ b/chrome/browser/task_manager/task_manager.cc
@@ -243,8 +243,7 @@ TaskManagerModel::TaskManagerModel(TaskManager* task_manager)
update_requests_(0),
listen_requests_(0),
update_state_(IDLE),
- goat_salt_(base::RandUint64()),
- last_unique_id_(0) {
+ goat_salt_(base::RandUint64()) {
AddResourceProvider(
new task_manager::BrowserProcessResourceProvider(task_manager));
AddResourceProvider(
@@ -318,19 +317,6 @@ base::ProcessHandle TaskManagerModel::GetProcess(int index) const {
return GetResource(index)->GetProcess();
}
-int TaskManagerModel::GetResourceUniqueId(int index) const {
- return GetResource(index)->get_unique_id();
-}
-
-int TaskManagerModel::GetResourceIndexByUniqueId(const int unique_id) const {
- for (int resource_index = 0; resource_index < ResourceCount();
- ++resource_index) {
- if (GetResourceUniqueId(resource_index) == unique_id)
- return resource_index;
- }
- return -1;
-}
-
base::string16 TaskManagerModel::GetResourceById(int index, int col_id) const {
if (IsSharedByGroup(col_id) && !IsResourceFirstInGroup(index))
return base::string16();
@@ -766,10 +752,6 @@ bool TaskManagerModel::IsResourceLastInGroup(int index) const {
return (group->back() == resource);
}
-bool TaskManagerModel::IsBackgroundResource(int index) const {
- return GetResource(index)->IsBackground();
-}
-
gfx::ImageSkia TaskManagerModel::GetResourceIcon(int index) const {
gfx::ImageSkia icon = GetResource(index)->GetIcon();
if (!icon.isNull())
@@ -978,14 +960,7 @@ WebContents* TaskManagerModel::GetResourceWebContents(int index) const {
return GetResource(index)->GetWebContents();
}
-const extensions::Extension* TaskManagerModel::GetResourceExtension(
- int index) const {
- return GetResource(index)->GetExtension();
-}
-
void TaskManagerModel::AddResource(Resource* resource) {
- resource->unique_id_ = ++last_unique_id_;
-
base::ProcessHandle process = resource->GetProcess();
ResourceList* group_entries = NULL;
@@ -1179,7 +1154,6 @@ void TaskManagerModel::Clear() {
FOR_EACH_OBSERVER(TaskManagerModelObserver, observer_list_,
OnItemsRemoved(0, size));
}
- last_unique_id_ = 0;
}
void TaskManagerModel::ModelChanged() {
« no previous file with comments | « chrome/browser/task_manager/task_manager.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698