Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5347)

Unified Diff: chrome/browser/task_manager/resource_provider.h

Issue 186153002: TaskManager: Remove some unused/unnecessary methods. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/task_manager/resource_provider.h
diff --git a/chrome/browser/task_manager/resource_provider.h b/chrome/browser/task_manager/resource_provider.h
index 16d48c2aa21432882aa3f1e9ed7bad2baff08f7f..a663bc28a0e9bbccb1ab30ff70f3b4bc6ca77799 100644
--- a/chrome/browser/task_manager/resource_provider.h
+++ b/chrome/browser/task_manager/resource_provider.h
@@ -73,9 +73,6 @@ class Resource {
virtual bool ReportsSqliteMemoryUsed() const;
virtual size_t SqliteMemoryUsedBytes() const;
- // Return extension associated with the resource, or NULL if not applicable.
- virtual const extensions::Extension* GetExtension() const;
-
virtual bool ReportsV8MemoryStats() const;
virtual size_t GetV8MemoryAllocated() const;
virtual size_t GetV8MemoryUsed() const;
@@ -114,10 +111,6 @@ class Resource {
virtual void NotifyV8HeapStats(size_t v8_memory_allocated,
size_t v8_memory_used) {}
- // Returns true if this resource is not visible to the user because it lives
- // in the background (e.g. extension background page, background contents).
- virtual bool IsBackground() const;
-
static const char* GetResourceTypeAsString(const Type type) {
switch (type) {
TASKMANAGER_RESOURCE_TYPE_LIST(TASKMANAGER_RESOURCE_TYPE_LIST_AS_STRING)
@@ -125,17 +118,10 @@ class Resource {
}
}
- // Returns resource identifier that is unique within single task manager
- // session (between StartUpdating and StopUpdating).
- int get_unique_id() { return unique_id_; }
-
protected:
- Resource() : unique_id_(0) {}
+ Resource() {}
private:
- friend class ::TaskManagerModel;
- int unique_id_;
-
DISALLOW_COPY_AND_ASSIGN(Resource);
};
« no previous file with comments | « chrome/browser/task_manager/panel_resource_provider.cc ('k') | chrome/browser/task_manager/resource_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698