Prepare StackFrame hierarchy & iterators for WASM

Prepare StackFrame hierarchy & iterators for WASM

This particularly changes the StackTraceFrameIterator such that is not
only returs JavaScriptFrames, but also WasmFrames. Because of that,
some methods (Summarize, function, receiver) were pulled up to the
StandardFrame, with specializations in JavaScriptFrame and WasmFrame.

R=jfb@chromium.org, titzer@chromium.org
BUG=

Committed: https://crrev.com/084544867233027d1fa0e761baafa78309d4ae65
Cr-Commit-Position: refs/heads/master@{#35293}

[titzer, 2016-04-06 09:53:23]

https://codereview.chromium.org/1861283002/diff/1/src/frames-inl.h
File src/frames-inl.h (right):

https://codereview.chromium.org/1861283002/diff/1/src/frames-inl.h#newcode288
src/frames-inl.h:288: bool StackTraceFrameIterator::isJS() const { return
frame()->is_java_script(); }
Spell out JavaScript here.

https://codereview.chromium.org/1861283002/diff/1/src/frames-inl.h#newcode292
src/frames-inl.h:292: JavaScriptFrame* StackTraceFrameIterator::jsFrame() const
{
CamelCase doesn't quite fit the surrounding style here, so I suggest
javascript_frame() for this and wasm_frame() for the one below.

https://codereview.chromium.org/1861283002/diff/1/src/frames.cc
File src/frames.cc (right):

https://codereview.chromium.org/1861283002/diff/1/src/frames.cc#newcode174
src/frames.cc:174: } while (!iterator_.done() &&
!IsValidFrame(iterator_.frame()));
might as well be consistent and use done() here instead of iterator_.done()

https://codereview.chromium.org/1861283002/diff/1/src/frames.cc#newcode1330
src/frames.cc:1330: Factory* factory = isolate()->factory();
Add a TODO here that we need to cache these JSFunctions that are materialized
for WASM.

https://codereview.chromium.org/1861283002/diff/1/src/frames.h
File src/frames.h (right):

https://codereview.chromium.org/1861283002/diff/1/src/frames.h#newcode1154
src/frames.h:1154: // JavaScript frames (that have proper JavaScript functions)
and WASM frames.
parens not necessary here

[Clemens Hammacher, 2016-04-06 10:18:29]

https://codereview.chromium.org/1861283002/diff/1/src/frames-inl.h
File src/frames-inl.h (right):

https://codereview.chromium.org/1861283002/diff/1/src/frames-inl.h#newcode288
src/frames-inl.h:288: bool StackTraceFrameIterator::isJS() const { return
frame()->is_java_script(); }
On 2016/04/06 09:53:23, titzer wrote:
> Spell out JavaScript here.

OK, changed it to is_javascript.

https://codereview.chromium.org/1861283002/diff/1/src/frames-inl.h#newcode292
src/frames-inl.h:292: JavaScriptFrame* StackTraceFrameIterator::jsFrame() const
{
On 2016/04/06 09:53:22, titzer wrote:
> CamelCase doesn't quite fit the surrounding style here, so I suggest
> javascript_frame() for this and wasm_frame() for the one below.

Done.

https://codereview.chromium.org/1861283002/diff/1/src/frames.cc
File src/frames.cc (right):

https://codereview.chromium.org/1861283002/diff/1/src/frames.cc#newcode174
src/frames.cc:174: } while (!iterator_.done() &&
!IsValidFrame(iterator_.frame()));
On 2016/04/06 09:53:23, titzer wrote:
> might as well be consistent and use done() here instead of iterator_.done()

Done.

https://codereview.chromium.org/1861283002/diff/1/src/frames.cc#newcode1330
src/frames.cc:1330: Factory* factory = isolate()->factory();
On 2016/04/06 09:53:23, titzer wrote:
> Add a TODO here that we need to cache these JSFunctions that are materialized
> for WASM.

Done.

https://codereview.chromium.org/1861283002/diff/1/src/frames.h
File src/frames.h (right):

https://codereview.chromium.org/1861283002/diff/1/src/frames.h#newcode1154
src/frames.h:1154: // JavaScript frames (that have proper JavaScript functions)
and WASM frames.
On 2016/04/06 09:53:23, titzer wrote:
> parens not necessary here

Acknowledged.

[Clemens Hammacher, 2016-04-06 10:21:18]

The CQ bit was checked by clemensh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-06 10:21:23]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1861283002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1861283002/20001

[Clemens Hammacher, 2016-04-06 10:21:25]

The CQ bit was unchecked by clemensh@chromium.org

[titzer, 2016-04-06 10:47:39]

lgtm, nice!

[Clemens Hammacher, 2016-04-06 11:04:18]

The CQ bit was checked by clemensh@chromium.org

[commit-bot: I haz the power, 2016-04-06 11:04:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1861283002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1861283002/20001

[commit-bot: I haz the power, 2016-04-06 11:37:24]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-06 11:38:27]

Description was changed from

==========
Prepare StackFrame hierarchy & iterators for WASM

This particularly changes the StackTraceFrameIterator such that is not
only returs JavaScriptFrames, but also WasmFrames. Because of that,
some methods (Summarize, function, receiver) were pulled up to the
StandardFrame, with specializations in JavaScriptFrame and WasmFrame.

R=jfb@chromium.org, titzer@chromium.org
BUG=
==========

to

==========
Prepare StackFrame hierarchy & iterators for WASM

This particularly changes the StackTraceFrameIterator such that is not
only returs JavaScriptFrames, but also WasmFrames. Because of that,
some methods (Summarize, function, receiver) were pulled up to the
StandardFrame, with specializations in JavaScriptFrame and WasmFrame.

R=jfb@chromium.org, titzer@chromium.org
BUG=

Committed: https://crrev.com/084544867233027d1fa0e761baafa78309d4ae65
Cr-Commit-Position: refs/heads/master@{#35293}
==========

[commit-bot: I haz the power, 2016-04-06 11:38:28]

Patchset 2 (id:??) landed as
https://crrev.com/084544867233027d1fa0e761baafa78309d4ae65
Cr-Commit-Position: refs/heads/master@{#35293}