src/profiler/sampling-heap-profiler.cc - Issue 1861283002: Prepare StackFrame hierarchy & iterators for WASM

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/profiler/sampling-heap-profiler.cc

Issue 1861283002: Prepare StackFrame hierarchy & iterators for WASM (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Address Ben's comments Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/profiler/sampling-heap-profiler.cc

diff --git a/src/profiler/sampling-heap-profiler.cc b/src/profiler/sampling-heap-profiler.cc

index a32cae3ef9c926c77aa448d614ca7ed2793cbec7..474dff20c057a4d53f8d1243a2da4d1ba6dd5e01 100644

--- a/src/profiler/sampling-heap-profiler.cc

+++ b/src/profiler/sampling-heap-profiler.cc

@@ -143,7 +143,7 @@ SamplingHeapProfiler::AllocationNode* SamplingHeapProfiler::AddStack() {

StackTraceFrameIterator it(isolate_);

int frames_captured = 0;

while (!it.done() && frames_captured < stack_depth_) {

- JavaScriptFrame* frame = it.frame();

+ StandardFrame* frame = it.frame();

SharedFunctionInfo* shared = frame->function()->shared();

stack.push_back(shared);

« no previous file with comments | « src/profiler/allocation-tracker.cc ('k') | test/cctest/compiler/test-run-inlining.cc » ('j') | no next file with comments »