src/profiler/allocation-tracker.cc - Issue 1861283002: Prepare StackFrame hierarchy & iterators for WASM

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/profiler/allocation-tracker.cc

Issue 1861283002: Prepare StackFrame hierarchy & iterators for WASM (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Address Ben's comments Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/profiler/allocation-tracker.cc

diff --git a/src/profiler/allocation-tracker.cc b/src/profiler/allocation-tracker.cc

index 791cdf03f0e9ca789bb09acce85d64308d651cc2..5572ed58380ae8a41441f7864c33ed75688fa711 100644

--- a/src/profiler/allocation-tracker.cc

+++ b/src/profiler/allocation-tracker.cc

@@ -233,7 +233,7 @@ void AllocationTracker::AllocationEvent(Address addr, int size) {

int length = 0;

StackTraceFrameIterator it(isolate);

while (!it.done() && length < kMaxAllocationTraceLength) {

- JavaScriptFrame* frame = it.frame();

+ StandardFrame* frame = it.frame();

SharedFunctionInfo* shared = frame->function()->shared();

SnapshotObjectId id = ids_->FindOrAddEntry(

shared->address(), shared->Size(), false);

« no previous file with comments | « src/isolate.cc ('k') | src/profiler/sampling-heap-profiler.cc » ('j') | no next file with comments »