Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Issue 186123004: Revert 255385 "aura: Remove client::UserActionClient." (Closed)

Created:
6 years, 9 months ago by Ben Goodger (Google)
Modified:
6 years, 9 months ago
Reviewers:
sadrul
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 255385 "aura: Remove client::UserActionClient." > aura: Remove client::UserActionClient. > > UserActionClient is used to navigate back/forward when the back/forward on a > supported mouse-device is clicked on X11. This can instead be achieved by > installing an event-handler on the browser window. > > This does change the behaviour a little on ChromeOS: clicking these navigation > buttons when the cursor is not on top of the browser window will not navigate > after this change. I have confirmed with UX that this is a desirable change. > > BUG=319636 > R=sky@chromium.org > > Review URL: https://codereview.chromium.org/183853037 TBR=sadrul@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255398

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -88 lines) Patch
M trunk/src/ash/shell.h View 2 chunks +2 lines, -0 lines 0 comments Download
M trunk/src/ash/shell.cc View 4 chunks +5 lines, -0 lines 0 comments Download
M trunk/src/ash/shell/shell_delegate_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/ash/shell/shell_delegate_impl.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/src/ash/shell_delegate.h View 2 chunks +6 lines, -0 lines 0 comments Download
M trunk/src/ash/test/test_shell_delegate.h View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/ash/test/test_shell_delegate.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/src/chrome/browser/ui/ash/chrome_shell_delegate.h View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/chrome/browser/ui/ash/chrome_shell_delegate.cc View 2 chunks +5 lines, -0 lines 0 comments Download
A + trunk/src/chrome/browser/ui/ash/user_action_handler.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/browser/ui/ash/user_action_handler.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
D trunk/src/chrome/browser/ui/views/frame/browser_command_handler_x11.h View 1 chunk +0 lines, -26 lines 0 comments Download
D trunk/src/chrome/browser/ui/views/frame/browser_command_handler_x11.cc View 1 chunk +0 lines, -46 lines 0 comments Download
M trunk/src/chrome/browser/ui/views/frame/browser_frame.h View 2 chunks +0 lines, -3 lines 0 comments Download
M trunk/src/chrome/browser/ui/views/frame/browser_frame.cc View 4 chunks +0 lines, -15 lines 0 comments Download
M trunk/src/chrome/browser/ui/views/frame/desktop_browser_frame_aura.h View 2 chunks +7 lines, -0 lines 0 comments Download
M trunk/src/chrome/browser/ui/views/frame/desktop_browser_frame_aura.cc View 2 chunks +6 lines, -0 lines 0 comments Download
A + trunk/src/chrome/browser/ui/views/frame/desktop_user_action_handler_aura.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/browser/ui/views/frame/desktop_user_action_handler_aura.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M trunk/src/chrome/chrome_browser_ui.gypi View 4 chunks +6 lines, -2 lines 0 comments Download
M trunk/src/ui/aura/aura.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
A + trunk/src/ui/aura/client/user_action_client.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/ui/aura/client/user_action_client.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M trunk/src/ui/aura/window_tree_host_x11.cc View 4 chunks +40 lines, -1 line 0 comments Download
M trunk/src/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc View 4 chunks +46 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Ben Goodger (Google)
6 years, 9 months ago (2014-03-06 18:07:44 UTC) #1
Ben Goodger (Google)
6 years, 9 months ago (2014-03-06 18:08:01 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r255398 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698