Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issue 183853037: aura: Remove client::UserActionClient. (Closed)

Created:
6 years, 9 months ago by sadrul
Modified:
6 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, ben+aura_chromium.org, tfarina, kalyank, ben+views_chromium.org, ben+ash_chromium.org
Visibility:
Public.

Description

aura: Remove client::UserActionClient. UserActionClient is used to navigate back/forward when the back/forward on a supported mouse-device is clicked on X11. This can instead be achieved by installing an event-handler on the browser window. This does change the behaviour a little on ChromeOS: clicking these navigation buttons when the cursor is not on top of the browser window will not navigate after this change. I have confirmed with UX that this is a desirable change. BUG=319636 R=sky@chromium.org Previously landed in r255385, reverted in r255398 to allow another revert in r255399. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255416

Patch Set 1 #

Patch Set 2 : fix-tests #

Patch Set 3 : unrevert #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -365 lines) Patch
M ash/shell.h View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M ash/shell.cc View 1 2 4 chunks +0 lines, -5 lines 0 comments Download
M ash/shell/shell_delegate_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M ash/shell/shell_delegate_impl.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ash/shell_delegate.h View 2 chunks +0 lines, -6 lines 0 comments Download
M ash/test/test_shell_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M ash/test/test_shell_delegate.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate.cc View 2 chunks +0 lines, -5 lines 0 comments Download
D chrome/browser/ui/ash/user_action_handler.h View 1 chunk +0 lines, -25 lines 0 comments Download
D chrome/browser/ui/ash/user_action_handler.cc View 1 chunk +0 lines, -54 lines 0 comments Download
A chrome/browser/ui/views/frame/browser_command_handler_x11.h View 1 chunk +26 lines, -0 lines 0 comments Download
A chrome/browser/ui/views/frame/browser_command_handler_x11.cc View 1 1 chunk +46 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_frame.h View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_frame.cc View 4 chunks +15 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/frame/desktop_browser_frame_aura.h View 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/frame/desktop_browser_frame_aura.cc View 2 chunks +0 lines, -6 lines 0 comments Download
D chrome/browser/ui/views/frame/desktop_user_action_handler_aura.h View 1 chunk +0 lines, -37 lines 0 comments Download
D chrome/browser/ui/views/frame/desktop_user_action_handler_aura.cc View 1 chunk +0 lines, -45 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 4 chunks +2 lines, -6 lines 0 comments Download
M ui/aura/aura.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
D ui/aura/client/user_action_client.h View 1 chunk +0 lines, -37 lines 0 comments Download
D ui/aura/client/user_action_client.cc View 1 chunk +0 lines, -30 lines 0 comments Download
M ui/aura/window_tree_host_x11.cc View 4 chunks +1 line, -40 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc View 1 2 4 chunks +1 line, -47 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sadrul
6 years, 9 months ago (2014-03-06 06:57:41 UTC) #1
sky
LGTM
6 years, 9 months ago (2014-03-06 16:41:39 UTC) #2
sadrul
Committed patchset #2 manually as r255385 (presubmit successful).
6 years, 9 months ago (2014-03-06 17:37:34 UTC) #3
sadrul
6 years, 9 months ago (2014-03-06 20:35:33 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r255416 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698