Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 1861003003: VisualRectMappingTest (Closed)

Created:
4 years, 8 months ago by Xianzhu
Modified:
4 years, 8 months ago
Reviewers:
chrishtr
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@Optional
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

VisualRectMappingTest Separate tests for visual rect mapping from LayoutObjectTest.cpp into VisualRectMappingTest. Add test for rect mapping using PaintInvalidationState. BUG=591199 Committed: https://crrev.com/6055aff7119f3d59c238e2a53dd79877f53e8411 Cr-Commit-Position: refs/heads/master@{#385477}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : CORE_EXPORT PaintInvalidationState #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -382 lines) Patch
M third_party/WebKit/Source/core/core.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObjectTest.cpp View 1 chunk +0 lines, -270 lines 0 comments Download
M third_party/WebKit/Source/core/layout/PaintInvalidationState.h View 1 2 4 chunks +5 lines, -4 lines 0 comments Download
A + third_party/WebKit/Source/core/layout/VisualRectMappingTest.cpp View 1 14 chunks +67 lines, -108 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 15 (7 generated)
Xianzhu
4 years, 8 months ago (2016-04-05 19:30:54 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1861003003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1861003003/40001
4 years, 8 months ago (2016-04-05 21:08:44 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-05 22:43:19 UTC) #6
chrishtr
lgtm
4 years, 8 months ago (2016-04-05 23:29:47 UTC) #8
commit-bot: I haz the power
This CL has an open dependency (Issue 1860143002 Patch 1). Please resolve the dependency and ...
4 years, 8 months ago (2016-04-05 23:30:06 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1861003003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1861003003/40001
4 years, 8 months ago (2016-04-06 16:37:15 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-06 16:42:53 UTC) #13
commit-bot: I haz the power
4 years, 8 months ago (2016-04-06 16:44:24 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6055aff7119f3d59c238e2a53dd79877f53e8411
Cr-Commit-Position: refs/heads/master@{#385477}

Powered by Google App Engine
This is Rietveld 408576698