Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1857373002: Fix PaintInvalidationState mapping for absolute whose container is above paintInvalidationContainer (Closed)

Created:
4 years, 8 months ago by Xianzhu
Modified:
4 years, 8 months ago
Reviewers:
chrishtr
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@VisualRectMappingTest
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix PaintInvalidationState mapping for absolute whose container is above paintInvalidationContainer BUG=591199 TEST=VisualRectMappingTest.ContainerOfAbsoluteAbovePaintInvalidationContainer Committed: https://crrev.com/733202f451285be6f37359c0e2a36eae2496ca6a Cr-Commit-Position: refs/heads/master@{#385501}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -21 lines) Patch
M third_party/WebKit/Source/core/layout/PaintInvalidationState.h View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/PaintInvalidationState.cpp View 5 chunks +36 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/core/layout/VisualRectMappingTest.cpp View 5 chunks +77 lines, -2 lines 0 comments Download

Depends on Patchset:

Issue 1861003003 Patch 40001

Dependent Patchsets:

Issue 1859833002 Patch 80001
Issue 1859833002 Patch 100001
Issue 1859833002 Patch 120001

Messages

Total messages: 11 (5 generated)
Xianzhu
4 years, 8 months ago (2016-04-05 22:04:19 UTC) #2
chrishtr
lgtm
4 years, 8 months ago (2016-04-06 00:34:07 UTC) #4
commit-bot: I haz the power
This CL has an open dependency (Issue 1861003003 Patch 40001). Please resolve the dependency and ...
4 years, 8 months ago (2016-04-06 00:34:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1857373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1857373002/1
4 years, 8 months ago (2016-04-06 16:43:32 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-06 17:46:43 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-06 17:48:09 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/733202f451285be6f37359c0e2a36eae2496ca6a
Cr-Commit-Position: refs/heads/master@{#385501}

Powered by Google App Engine
This is Rietveld 408576698