Allow Vector<Optional> and Optional::get()

Allow Vector<Optional> and Optional::get()

Vector<Optional> is useful to manage variable number of optional objects.
This CL allows Optional class to use placement 'new' so that we can use
Vector<Optional>.

Optional::get() is useful to get the pointer (nullptr if the object is not
emplaced) to the optional object. It's a short form of equivalent but more
verbose form "optionalObject ? &*optionalObject : nullptr".

Committed: https://crrev.com/684b685bf914256f43065bebee80038e53ac5c52
Cr-Commit-Position: refs/heads/master@{#385397}

[Xianzhu, 2016-04-05 18:28:37]

wangxianzhu@chromium.org changed reviewers:
+ jochen@chromium.org

[Xianzhu, 2016-04-05 18:28:38]

I need Vector<Optional<PaintInvalidationState>> in a unit test.

Optional::get() is needed by my another CL. It's a shortcut of "optional ?
&*optional : nullptr".

[Xianzhu, 2016-04-06 00:19:43]

wangxianzhu@chromium.org changed reviewers:
+ haraken@chromium.org

[haraken, 2016-04-06 00:24:00]

Would you give me a link to your CL?

Also add more rationale to the CL description.

[Xianzhu, 2016-04-06 00:31:04]

On 2016/04/06 00:24:00, haraken wrote:
> Would you give me a link to your CL?
> 
> Also add more rationale to the CL description.

The place where I need Vector<Optional>:
https://codereview.chromium.org/1861003003/diff/20001/third_party/WebKit/Sour...

The place where I need Optional::get():
https://codereview.chromium.org/1774193002/diff/220001/third_party/WebKit/Sou...

[haraken, 2016-04-06 00:35:37]

LGTM % more CL description.

[Xianzhu, 2016-04-06 06:20:16]

Description was changed from

==========
Allow Vector<Optional> and Optional::get()
==========

to

==========
Allow Vector<Optional> and Optional::get()

Vector<Optional> is useful to manage variable number of optional objects.
This CL allows Optional class to use placement 'new' so that we can use
Vector<Optional>.

Optional::get() is useful to get the pointer (nullptr if the object is not
emplaced) to the optional object. It's a short form of more verbose equivalence
'optionalObject ? &*optionalObject : nullptr'.
==========

[Xianzhu, 2016-04-06 06:20:32]

On 2016/04/06 00:35:37, haraken wrote:
> LGTM % more CL description.

Updated CL description.

[Xianzhu, 2016-04-06 06:21:28]

Description was changed from

==========
Allow Vector<Optional> and Optional::get()

Vector<Optional> is useful to manage variable number of optional objects.
This CL allows Optional class to use placement 'new' so that we can use
Vector<Optional>.

Optional::get() is useful to get the pointer (nullptr if the object is not
emplaced) to the optional object. It's a short form of more verbose equivalence
'optionalObject ? &*optionalObject : nullptr'.
==========

to

==========
Allow Vector<Optional> and Optional::get()

Vector<Optional> is useful to manage variable number of optional objects.
This CL allows Optional class to use placement 'new' so that we can use
Vector<Optional>.

Optional::get() is useful to get the pointer (nullptr if the object is not
emplaced) to the optional object. It's a short form of equivalent but more
verbose form "optionalObject ? &*optionalObject : nullptr".
==========

[Xianzhu, 2016-04-06 06:21:48]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2016-04-06 06:22:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1860143002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1860143002/1

[commit-bot: I haz the power, 2016-04-06 07:32:30]

Description was changed from

==========
Allow Vector<Optional> and Optional::get()

Vector<Optional> is useful to manage variable number of optional objects.
This CL allows Optional class to use placement 'new' so that we can use
Vector<Optional>.

Optional::get() is useful to get the pointer (nullptr if the object is not
emplaced) to the optional object. It's a short form of equivalent but more
verbose form "optionalObject ? &*optionalObject : nullptr".
==========

to

==========
Allow Vector<Optional> and Optional::get()

Vector<Optional> is useful to manage variable number of optional objects.
This CL allows Optional class to use placement 'new' so that we can use
Vector<Optional>.

Optional::get() is useful to get the pointer (nullptr if the object is not
emplaced) to the optional object. It's a short form of equivalent but more
verbose form "optionalObject ? &*optionalObject : nullptr".
==========

[commit-bot: I haz the power, 2016-04-06 07:32:31]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-06 07:34:47]

Description was changed from

==========
Allow Vector<Optional> and Optional::get()

Vector<Optional> is useful to manage variable number of optional objects.
This CL allows Optional class to use placement 'new' so that we can use
Vector<Optional>.

Optional::get() is useful to get the pointer (nullptr if the object is not
emplaced) to the optional object. It's a short form of equivalent but more
verbose form "optionalObject ? &*optionalObject : nullptr".
==========

to

==========
Allow Vector<Optional> and Optional::get()

Vector<Optional> is useful to manage variable number of optional objects.
This CL allows Optional class to use placement 'new' so that we can use
Vector<Optional>.

Optional::get() is useful to get the pointer (nullptr if the object is not
emplaced) to the optional object. It's a short form of equivalent but more
verbose form "optionalObject ? &*optionalObject : nullptr".

Committed: https://crrev.com/684b685bf914256f43065bebee80038e53ac5c52
Cr-Commit-Position: refs/heads/master@{#385397}
==========

[commit-bot: I haz the power, 2016-04-06 07:34:47]

Patchset 1 (id:??) landed as
https://crrev.com/684b685bf914256f43065bebee80038e53ac5c52
Cr-Commit-Position: refs/heads/master@{#385397}