Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1860903002: Update Source/platform/ to assume Oilpan only. (Closed)

Created:
4 years, 8 months ago by sof
Modified:
4 years, 8 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, shans, blink-reviews-platform-graphics_chromium.org, dshwang, kinuko+watch, rwlbuis, krit, drott+blinkwatch_chromium.org, Justin Novosad, Rik, gavinp+loader_chromium.org, loading-reviews_chromium.org, Eric Willigers, rjwright, Mads Ager (chromium), jbroman, blink-reviews, pdr+graphicswatchlist_chromium.org, darktears, Nate Chapin, Stephen Chennney, tyoshino+watch_chromium.org, blink-reviews-animation_chromium.org, blink-layers+watch_chromium.org, f(malita), oilpan-reviews, danakj+watch_chromium.org, kouhei+heap_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update Source/platform/ to assume Oilpan only. R=haraken BUG=585328 Committed: https://crrev.com/5b96b688768edf68cbe8d34b3db1ef5a85d85ec8 Cr-Commit-Position: refs/heads/master@{#385145}

Patch Set 1 #

Patch Set 2 : rebased #

Patch Set 3 : back out ScrollAnimatorMac() accidental change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+170 lines, -241 lines) Patch
M third_party/WebKit/Source/core/loader/EmptyClients.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/EmptyClients.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/AsyncMethodRunner.h View 2 chunks +0 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/platform/MemoryPurgeController.h View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/MemoryPurgeController.cpp View 2 chunks +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/Widget.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/Font.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/fonts/Font.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/fonts/FontCache.h View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/FontCache.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/FontFallbackList.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/fonts/FontFallbackList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsLayerTest.cpp View 1 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FEBlend.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FEBlend.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FEBoxReflect.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FEBoxReflect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FEColorMatrix.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FEColorMatrix.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FEComponentTransfer.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FEComponentTransfer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FEComposite.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FEComposite.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FEConvolveMatrix.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FEConvolveMatrix.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FEDiffuseLighting.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FEDiffuseLighting.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FEDisplacementMap.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FEDisplacementMap.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FEDropShadow.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FEDropShadow.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FEFlood.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FEFlood.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FEGaussianBlur.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FEGaussianBlur.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FEMerge.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FEMerge.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FEMorphology.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FEMorphology.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FEOffset.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FEOffset.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FESpecularLighting.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FESpecularLighting.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FETile.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FETile.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FETurbulence.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FETurbulence.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/Filter.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/Filter.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FilterOperation.h View 14 chunks +15 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FilterOperation.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FilterOperations.h View 3 chunks +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/ImageFilterBuilderTest.cpp View 2 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/PaintFilterEffect.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/PaintFilterEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/SourceAlpha.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/SourceAlpha.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/SourceGraphic.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/SourceGraphic.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/heap/MarkingVisitorImpl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/mac/ScrollAnimatorMac.mm View 1 2 3 chunks +1 line, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/mhtml/ArchiveResource.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/mhtml/ArchiveResource.cpp View 2 chunks +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/mhtml/MHTMLArchive.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/mhtml/MHTMLArchive.cpp View 5 chunks +4 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/mhtml/MHTMLParser.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/mhtml/MHTMLParser.cpp View 9 chunks +13 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ProgrammaticScrollAnimator.h View 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/scroll/ProgrammaticScrollAnimator.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollAnimator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollAnimatorBase.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.cpp View 2 chunks +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollAnimatorTest.cpp View 8 chunks +15 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollableArea.h View 2 chunks +2 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollableArea.cpp View 3 chunks +2 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollableAreaTest.cpp View 8 chunks +17 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/Scrollbar.h View 3 chunks +8 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/Scrollbar.cpp View 1 chunk +0 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/platform/testing/FontTestHelpers.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/text/TextCheckerClient.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/SpellCheckerClientImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/SpellCheckerClientImpl.cpp View 1 chunk +7 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
sof
please take a look.
4 years, 8 months ago (2016-04-05 08:49:17 UTC) #2
haraken
LGTM
4 years, 8 months ago (2016-04-05 08:53:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1860903002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1860903002/40001
4 years, 8 months ago (2016-04-05 09:27:08 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-05 09:56:30 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-05 09:57:49 UTC) #10
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/5b96b688768edf68cbe8d34b3db1ef5a85d85ec8
Cr-Commit-Position: refs/heads/master@{#385145}

Powered by Google App Engine
This is Rietveld 408576698