Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(537)

Unified Diff: third_party/WebKit/Source/platform/scroll/ScrollableArea.h

Issue 1860903002: Update Source/platform/ to assume Oilpan only. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: back out ScrollAnimatorMac() accidental change Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/scroll/ScrollableArea.h
diff --git a/third_party/WebKit/Source/platform/scroll/ScrollableArea.h b/third_party/WebKit/Source/platform/scroll/ScrollableArea.h
index cea0e0e73d0c4ace4064782c6f53c97ce575c477..87912f4dc4075a9a6434fa63c0f0d6473ea73688 100644
--- a/third_party/WebKit/Source/platform/scroll/ScrollableArea.h
+++ b/third_party/WebKit/Source/platform/scroll/ScrollableArea.h
@@ -62,16 +62,7 @@ enum IncludeScrollbarsInRect {
IncludeScrollbars,
};
-#if ENABLE(OILPAN)
-// Oilpan: Using the transition type GarbageCollectedMixin is
-// problematic non-Oilpan as the type expands to DummyBase, exporting it
-// also from 'platform' as a result. Bringing about duplicate DummyBases
-// as core also exports same; with component build linking fails as a
-// result. Hence the workaround of not using a transition type.
class PLATFORM_EXPORT ScrollableArea : public GarbageCollectedMixin {
-#else
-class PLATFORM_EXPORT ScrollableArea {
-#endif
WTF_MAKE_NONCOPYABLE(ScrollableArea);
public:
static int pixelsPerLineStep(HostWindow*);
@@ -130,10 +121,10 @@ public:
ScrollAnimatorBase& scrollAnimator() const;
// This getter will return null if the ScrollAnimatorBase hasn't been created yet.
- ScrollAnimatorBase* existingScrollAnimator() const { return m_scrollAnimator.get(); }
+ ScrollAnimatorBase* existingScrollAnimator() const { return m_scrollAnimator; }
ProgrammaticScrollAnimator& programmaticScrollAnimator() const;
- ProgrammaticScrollAnimator* existingProgrammaticScrollAnimator() const { return m_programmaticScrollAnimator.get(); }
+ ProgrammaticScrollAnimator* existingProgrammaticScrollAnimator() const { return m_programmaticScrollAnimator; }
virtual CompositorAnimationTimeline* compositorAnimationTimeline() const { return nullptr; }

Powered by Google App Engine
This is Rietveld 408576698