Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 1860273003: Downgrade some lifecycle update calls to not include paint if not necessary. (Closed)

Created:
4 years, 8 months ago by chrishtr
Modified:
4 years, 8 months ago
Reviewers:
Xianzhu
CC:
aboxhall, blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dmazzoni, dshwang, krit, dtapuska+blinkwatch_chromium.org, f(malita), fs, gyuyoung2, je_julie, kouhei+svg_chromium.org, nektarios, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, slimming-paint-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Downgrade some lifecycle update calls to not include paint if not necessary. BUG=591468 Committed: https://crrev.com/8a021f4923a66c50ed1a83fc0e1dc1b4d1add8a3 Cr-Commit-Position: refs/heads/master@{#386304}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -7 lines) Patch
M third_party/WebKit/Source/core/frame/LocalFrame.cpp View 1 2 4 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/input/EventHandler.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp View 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebAXObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.cpp View 1 2 3 4 5 2 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 21 (9 generated)
chrishtr
4 years, 8 months ago (2016-04-06 00:34:57 UTC) #3
Xianzhu
It seems that the change about SVGImage caused test failures.
4 years, 8 months ago (2016-04-06 16:36:51 UTC) #4
chrishtr
On 2016/04/06 at 16:36:51, wangxianzhu wrote: > It seems that the change about SVGImage caused ...
4 years, 8 months ago (2016-04-06 19:27:09 UTC) #5
Xianzhu
lgtm
4 years, 8 months ago (2016-04-06 19:37:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1860273003/50005 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1860273003/50005
4 years, 8 months ago (2016-04-06 19:38:15 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/200695)
4 years, 8 months ago (2016-04-06 20:47:50 UTC) #10
chrishtr
I had to revert one call site in printing. Not sure why it happens, left ...
4 years, 8 months ago (2016-04-06 22:10:35 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1860273003/110001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1860273003/110001
4 years, 8 months ago (2016-04-06 22:11:36 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/206966)
4 years, 8 months ago (2016-04-07 01:46:15 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1860273003/110001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1860273003/110001
4 years, 8 months ago (2016-04-09 17:55:03 UTC) #18
commit-bot: I haz the power
Committed patchset #7 (id:110001)
4 years, 8 months ago (2016-04-09 19:11:56 UTC) #19
commit-bot: I haz the power
4 years, 8 months ago (2016-04-09 19:13:08 UTC) #21
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/8a021f4923a66c50ed1a83fc0e1dc1b4d1add8a3
Cr-Commit-Position: refs/heads/master@{#386304}

Powered by Google App Engine
This is Rietveld 408576698