third_party/WebKit/Source/core/input/EventHandler.cpp - Issue 1860273003: Downgrade some lifecycle update calls to not include paint if not necessary.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/input/EventHandler.cpp

Issue 1860273003: Downgrade some lifecycle update calls to not include paint if not necessary. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/frame/LocalFrame.cpp ('k') | third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/input/EventHandler.cpp

diff --git a/third_party/WebKit/Source/core/input/EventHandler.cpp b/third_party/WebKit/Source/core/input/EventHandler.cpp

index e3cfaf7cb01c70fbe6631718c17cf2e5526dab3c..d3905cfedc561668e193cbe11a94cc62efd00d1d 100644

--- a/third_party/WebKit/Source/core/input/EventHandler.cpp

+++ b/third_party/WebKit/Source/core/input/EventHandler.cpp

@@ -2130,7 +2130,7 @@ WebInputEventResult EventHandler::handleGestureTap(const GestureEventWithHitTest

if (currentHitTest.innerNode()) {

LocalFrame* mainFrame = m_frame->localFrameRoot();

if (mainFrame && mainFrame->view())

- mainFrame->view()->updateAllLifecyclePhases();

+ mainFrame->view()->updateLifecycleToCompositingCleanPlusScrolling();

adjustedPoint = frameView->rootFrameToContents(gestureEvent.position());

currentHitTest = hitTestResultInFrame(m_frame, adjustedPoint, hitType);

}

« no previous file with comments | « third_party/WebKit/Source/core/frame/LocalFrame.cpp ('k') | third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp » ('j') | no next file with comments »