Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Unified Diff: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

Issue 1860273003: Downgrade some lifecycle update calls to not include paint if not necessary. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/web/WebAXObject.cpp ('k') | third_party/WebKit/Source/web/WebViewImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
index 9166284ff3b5fa6386294b51007dca982963bba5..cf54bcac3dd83f62f1c890e375a9bad706897091 100644
--- a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
+++ b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
@@ -304,7 +304,7 @@ public:
if (!frame()->document() || !frame()->document()->layoutView())
return 0;
- frame()->view()->updateAllLifecyclePhases();
+ frame()->view()->updateLifecycleToCompositingCleanPlusScrolling();
if (!frame()->document() || !frame()->document()->layoutView())
return 0;
@@ -323,6 +323,8 @@ public:
if (!frame()->document() || !frame()->document()->layoutView())
return;
+ // TODO(chrishtr): this should be updateLifecycleToCompositingCleanPlusScrolling, but
+ // for some reason it makes printing/absolute-position-headers-and-footers.html fail.
frame()->view()->updateAllLifecyclePhases();
if (!frame()->document() || !frame()->document()->layoutView())
return;
« no previous file with comments | « third_party/WebKit/Source/web/WebAXObject.cpp ('k') | third_party/WebKit/Source/web/WebViewImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698