Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Unified Diff: ppapi/api/pp_var.idl

Issue 18599005: [PPAPI] Added PP_VARTYPE_RESOURCE as a PP_VarType enum value. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Fix unittest_utils comparison of resource vars. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ppapi/api/pp_var.idl
diff --git a/ppapi/api/pp_var.idl b/ppapi/api/pp_var.idl
index aeeb7bf8fd8d87bc9faf4d90a418a16ccdb047af..b2e3f32d33c0b662c5056222689fc6236aa4128c 100644
--- a/ppapi/api/pp_var.idl
+++ b/ppapi/api/pp_var.idl
@@ -81,7 +81,14 @@ enum PP_VarType {
* ArrayBuffer vars. These objects are reference counted, so AddRef and
* Release must be used properly to avoid memory leaks.
*/
- PP_VARTYPE_ARRAY_BUFFER = 9
+ PP_VARTYPE_ARRAY_BUFFER = 9,
+
+ /**
+ * Resources are not currently supported but will be added in future
+ * revisions. These objects are reference counted, so AddRef and Release must
raymes 2013/09/11 22:52:29 future revisions -> the future
Matt Giuca 2013/09/12 07:08:24 Done. (Haha, note that I copied this text from the
+ * be used properly to avoid memory leaks.
+ */
+ PP_VARTYPE_RESOURCE = 10
};
@@ -113,12 +120,12 @@ enum PP_VarType {
/**
* If <code>type</code> is <code>PP_VARTYPE_STRING</code>,
- * <code>PP_VARTYPE_OBJECT</code>, <code>PP_VARTYPE_ARRAY</code>, or
- * <code>PP_VARTYPE_DICTIONARY</code>,
- * <code>as_id</code> represents the value of this <code>PP_Var</code> as
- * an opaque handle assigned by the browser. This handle is guaranteed
- * never to be 0, so a module can initialize this ID to 0 to indicate a
- * "NULL handle."
+ * <code>PP_VARTYPE_OBJECT</code>, <code>PP_VARTYPE_ARRAY</code>,
+ * <code>PP_VARTYPE_DICTIONARY</code>, <code>PP_VARTYPE_ARRAY_BUFFER</code>,
+ * or <code>PP_VARTYPE_RESOURCE</code>, <code>as_id</code> represents the
+ * value of this <code>PP_Var</code> as an opaque handle assigned by the
+ * browser. This handle is guaranteed never to be 0, so a module can
+ * initialize this ID to 0 to indicate a "NULL handle."
*/
int64_t as_id;
};

Powered by Google App Engine
This is Rietveld 408576698