Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Unified Diff: ppapi/proxy/raw_var_data.cc

Issue 18599005: [PPAPI] Added PP_VARTYPE_RESOURCE as a PP_VarType enum value. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Fix unittest_utils comparison of resource vars. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ppapi/proxy/raw_var_data.cc
diff --git a/ppapi/proxy/raw_var_data.cc b/ppapi/proxy/raw_var_data.cc
index a550c3fca052892976c32288a6b807fa4cff211f..6379c7a2aa8c7913442c0771945bf4fb2948fb18 100644
--- a/ppapi/proxy/raw_var_data.cc
+++ b/ppapi/proxy/raw_var_data.cc
@@ -240,6 +240,13 @@ RawVarData* RawVarData::Create(PP_VarType type) {
return new ArrayRawVarData();
case PP_VARTYPE_DICTIONARY:
return new DictionaryRawVarData();
+ case PP_VARTYPE_RESOURCE:
+ // TODO(mgiuca): Add ResourceRawVarData. (http://crbug.com/177017)
+ // This path will be reached if a NaCl module attempts to pass a
+ // PP_VARTYPE_RESOURCE in a message.
+ NOTIMPLEMENTED();
+ CHECK(false) << "Serializing PP_VARTYPE_RESOURCE is not supported.";
raymes 2013/09/11 22:52:29 I realise that you are going to be changing this s
Matt Giuca 2013/09/12 07:08:24 OK, fair enough. That will result in a NULL point
+ return NULL;
}
NOTREACHED();
return NULL;

Powered by Google App Engine
This is Rietveld 408576698