content/renderer/pepper/v8_var_converter.cc - Issue 18599005: [PPAPI] Added PP_VARTYPE_RESOURCE as a PP_VarType enum value.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/pepper/v8_var_converter.cc

Issue 18599005: [PPAPI] Added PP_VARTYPE_RESOURCE as a PP_VarType enum value. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Fix unittest_utils comparison of resource vars. Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/pepper/v8_var_converter.cc

diff --git a/content/renderer/pepper/v8_var_converter.cc b/content/renderer/pepper/v8_var_converter.cc

index 61bb96131137c106eec6beddfee00c69e798e596..e11aa6d2fdfde0941742f2e48c1f640597c8b439 100644

--- a/content/renderer/pepper/v8_var_converter.cc

+++ b/content/renderer/pepper/v8_var_converter.cc

@@ -148,6 +148,9 @@ bool GetOrCreateV8Value(const PP_Var& var,

*result = v8::Object::New();

break;

case PP_VARTYPE_OBJECT:

+ case PP_VARTYPE_RESOURCE:

+ // TODO(mgiuca): Convert PP_VARTYPE_RESOURCE vars into the correct V8

+ // type. (http://crbug.com/177017)

NOTREACHED();

result->Clear();

return false;