bluetooth: Remove disconnect when page hidden

bluetooth: Remove disconnect when page hidden

Also removes the permission check when disconnecting. This stops the renderer
crashing when the renderer tries to disconnect a device after a test has
finished and the browser state has been cleared.

BUG=554240, 600014, 579746
Committed: https://crrev.com/47e15c538f5c24300e6a02bd71016ba70ae5a0a3
Cr-Commit-Position: refs/heads/master@{#384989}

[ortuno, 2016-04-04 14:34:25]

The CQ bit was checked by ortuno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-04 14:34:45]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1859463002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1859463002/1

[ortuno, 2016-04-04 15:12:08]

ortuno@chromium.org changed reviewers:
+ jyasskin@chromium.org

[ortuno, 2016-04-04 15:12:08]

jyasskin: PTAL

[commit-bot: I haz the power, 2016-04-04 16:30:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-04 16:30:19]

Dry run: This issue passed the CQ dry run.

[Jeffrey Yasskin, 2016-04-04 16:56:05]

Description was changed from

==========
bluetooth: Remove disconnect when page hidden

Also removes the permission check when disconnecting. This stops the renderer
crashing when the renderer tries to disconnect a device after a test has
finished and the browser state has been cleared.

BUG=554240,600014
==========

to

==========
bluetooth: Remove disconnect when page hidden

Also removes the permission check when disconnecting. This stops the renderer
crashing when the renderer tries to disconnect a device after a test has
finished and the browser state has been cleared.

BUG=554240,600014,579746
==========

[Jeffrey Yasskin, 2016-04-04 17:06:39]

lgtm

https://codereview.chromium.org/1859463002/diff/1/content/browser/bluetooth/b...
File content/browser/bluetooth/bluetooth_dispatcher_host.cc (left):

https://codereview.chromium.org/1859463002/diff/1/content/browser/bluetooth/b...
content/browser/bluetooth/bluetooth_dispatcher_host.cc:704: // Make sure the
origin is allowed to access the device. We perform this check
Add a comment about why we're *not* checking the origin in this call.
Specifically, frames can send a disconnect request after they've started
navigating, and then the GetOrigin() call is invalid. And we have to continue
the execution so that navigating itself disconnects?

[ortuno, 2016-04-04 18:04:12]

Thanks!

https://codereview.chromium.org/1859463002/diff/1/content/browser/bluetooth/b...
File content/browser/bluetooth/bluetooth_dispatcher_host.cc (left):

https://codereview.chromium.org/1859463002/diff/1/content/browser/bluetooth/b...
content/browser/bluetooth/bluetooth_dispatcher_host.cc:704: // Make sure the
origin is allowed to access the device. We perform this check
On 2016/04/04 at 17:06:39, Jeffrey Yasskin wrote:
> Add a comment about why we're *not* checking the origin in this call.
Specifically, frames can send a disconnect request after they've started
navigating, and then the GetOrigin() call is invalid. And we have to continue
the execution so that navigating itself disconnects?

Done.

[ortuno, 2016-04-04 18:04:18]

The CQ bit was checked by ortuno@chromium.org

[ortuno, 2016-04-04 18:04:18]

The patchset sent to the CQ was uploaded after l-g-t-m from
jyasskin@chromium.org
Link to the patchset: https://codereview.chromium.org/1859463002/#ps20001
(title: "Address jyasskin's comments")

[commit-bot: I haz the power, 2016-04-04 18:04:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1859463002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1859463002/20001

[commit-bot: I haz the power, 2016-04-04 20:18:29]

Description was changed from

==========
bluetooth: Remove disconnect when page hidden

Also removes the permission check when disconnecting. This stops the renderer
crashing when the renderer tries to disconnect a device after a test has
finished and the browser state has been cleared.

BUG=554240,600014,579746
==========

to

==========
bluetooth: Remove disconnect when page hidden

Also removes the permission check when disconnecting. This stops the renderer
crashing when the renderer tries to disconnect a device after a test has
finished and the browser state has been cleared.

BUG=554240,600014,579746
==========

[commit-bot: I haz the power, 2016-04-04 20:18:30]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-04 20:19:55]

Description was changed from

==========
bluetooth: Remove disconnect when page hidden

Also removes the permission check when disconnecting. This stops the renderer
crashing when the renderer tries to disconnect a device after a test has
finished and the browser state has been cleared.

BUG=554240,600014,579746
==========

to

==========
bluetooth: Remove disconnect when page hidden

Also removes the permission check when disconnecting. This stops the renderer
crashing when the renderer tries to disconnect a device after a test has
finished and the browser state has been cleared.

BUG=554240,600014,579746

Committed: https://crrev.com/47e15c538f5c24300e6a02bd71016ba70ae5a0a3
Cr-Commit-Position: refs/heads/master@{#384989}
==========

[commit-bot: I haz the power, 2016-04-04 20:19:56]

Patchset 2 (id:??) landed as
https://crrev.com/47e15c538f5c24300e6a02bd71016ba70ae5a0a3
Cr-Commit-Position: refs/heads/master@{#384989}

[haraken, 2016-04-05 00:01:31]

LGTM