bluetooth: Remove disconnect when page hidden

third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTServer.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "modules/bluetooth/BluetoothRemoteGATTServer.h"
 
 #include "bindings/core/v8/CallbackPromiseAdapter.h"
 #include "bindings/core/v8/ScriptPromise.h"
 #include "bindings/core/v8/ScriptPromiseResolver.h"
 #include "core/dom/DOMException.h"
-#include "core/dom/Document.h"
 #include "core/dom/ExceptionCode.h"
-#include "core/page/Page.h"
 #include "modules/bluetooth/BluetoothError.h"
 #include "modules/bluetooth/BluetoothRemoteGATTService.h"
 #include "modules/bluetooth/BluetoothSupplement.h"
 #include "modules/bluetooth/BluetoothUUID.h"
 #include "public/platform/modules/bluetooth/WebBluetooth.h"
 #include "wtf/OwnPtr.h"
 
 namespace blink {
-namespace {
-
-const char kPageHiddenError[] = "Connection is only allowed while the page is visible. This is a temporary measure until we are able to effectively communicate to the user that a page is connected to a device.";
-
-}
 
 BluetoothRemoteGATTServer::BluetoothRemoteGATTServer(BluetoothDevice* device)
     : m_device(device)
     , m_connected(false)
 {
 }
 
 BluetoothRemoteGATTServer* BluetoothRemoteGATTServer::create(BluetoothDevice* device)
 {
     return new BluetoothRemoteGATTServer(device);
 }
 
 DEFINE_TRACE(BluetoothRemoteGATTServer)
 {
     visitor->trace(m_device);
 }
 
 class ConnectCallback : public WebBluetoothRemoteGATTServerConnectCallbacks {
 public:
     ConnectCallback(BluetoothDevice* device, ScriptPromiseResolver* resolver)
         : m_device(device)
         , m_resolver(resolver) {}
 
     void onSuccess() override
     {
         if (!m_resolver->getExecutionContext() || m_resolver->getExecutionContext()->activeDOMObjectsAreStopped())
             return;
         m_device->gatt()->setConnected(true);
-        if (!m_device->page()->isPageVisible()) {
-            // TODO(ortuno): Allow connections when the tab is in the background.
-            // This is a short term solution instead of implementing a tab indicator
-            // for bluetooth connections.
-            // https://crbug.com/579746
-            m_device->disconnectGATTIfConnected();
-            m_resolver->reject(DOMException::create(SecurityError, kPageHiddenError));
-        } else {
-            m_resolver->resolve(m_device->gatt());
-        }
+        m_resolver->resolve(m_device->gatt());
     }
 
     void onError(const WebBluetoothError& e) override
     {
         if (!m_resolver->getExecutionContext() || m_resolver->getExecutionContext()->activeDOMObjectsAreStopped())
             return;
         m_resolver->reject(BluetoothError::take(m_resolver, e));
     }
 private:
     Persistent<BluetoothDevice> m_device;
     Persistent<ScriptPromiseResolver> m_resolver;
 };
 
 ScriptPromise BluetoothRemoteGATTServer::connect(ScriptState* scriptState)
 {
-    // TODO(ortuno): Allow connections when the tab is in the background.
-    // This is a short term solution instead of implementing a tab indicator
-    // for bluetooth connections.
-    // https://crbug.com/579746
-    if (!toDocument(scriptState->getExecutionContext())->page()->isPageVisible()) {
-        return ScriptPromise::rejectWithDOMException(scriptState, DOMException::create(SecurityError, kPageHiddenError));
-    }
-
     WebBluetooth* webbluetooth = BluetoothSupplement::fromScriptState(scriptState);
     if (!webbluetooth)
         return ScriptPromise::rejectWithDOMException(scriptState, DOMException::create(NotSupportedError));
 
     ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(scriptState);
     ScriptPromise promise = resolver->promise();
     webbluetooth->connect(device()->id(), new ConnectCallback(device(), resolver));
     return promise;
 }
 
@@ skipping 13 matching lines @@
         return exceptionState.reject(scriptState);
 
     ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(scriptState);
     ScriptPromise promise = resolver->promise();
     webbluetooth->getPrimaryService(device()->id(), serviceUUID, new CallbackPromiseAdapter<BluetoothRemoteGATTService, BluetoothError>(resolver));
 
     return promise;
 }
 
 } // namespace blink