Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Unified Diff: third_party/WebKit/LayoutTests/bluetooth/connect.html

Issue 1859463002: bluetooth: Remove disconnect when page hidden (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address jyasskin's comments Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/bluetooth/connect.html
diff --git a/third_party/WebKit/LayoutTests/bluetooth/connect.html b/third_party/WebKit/LayoutTests/bluetooth/connect.html
index f69ff8f99a86df799e0226da21a6bbb2da5bada6..cf399342a2c6b3ffbab18dacab25399f6881a2dc 100644
--- a/third_party/WebKit/LayoutTests/bluetooth/connect.html
+++ b/third_party/WebKit/LayoutTests/bluetooth/connect.html
@@ -124,34 +124,6 @@ promise_test(() => {
}, testSpec.testName);
});
-// TODO(ortuno): Allow connections when the tab is in the background.
-// This is a short term solution instead of implementing a tab indicator
-// for bluetooth connections.
-// https://crbug.com/579746
-promise_test(() => {
- return setBluetoothFakeAdapter('HeartRateAdapter')
- .then(() => requestDeviceWithKeyDown({
- filters: [{services: ['heart_rate']}]}))
- .then(device => {
- testRunner.setPageVisibility('hidden');
- return assert_promise_rejects_with_message(
- device.gatt.connect(),
- new DOMException('Connection is only allowed while the page is visible. ' +
- 'This is a temporary measure until we are able to ' +
- 'effectively communicate to the user that a page is ' +
- 'connected to a device.',
- 'SecurityError'))
- .then(() => {
- assert_false(device.gatt.connected);
- });
- })
- .then(() => testRunner.setPageVisibility('visible'))
- .catch(error => {
- testRunner.setPageVisibility('visible');
- throw error;
- });
-}, 'Device should not be able to connect in background.');
-
promise_test(() => {
return setBluetoothFakeAdapter('HeartRateAdapter')
.then(() => requestDeviceWithKeyDown({

Powered by Google App Engine
This is Rietveld 408576698