Add a one-time notice about other forms of browsing history.

Add a one-time notice about other forms of browsing history.

Design doc:
https://docs.google.com/document/d/1ZMDSAd44KmzKhqXPjobZOf9rZezs6VqiBnqpDD0auCU/

Mocks:
https://docs.google.com/presentation/d/1rpR3xB3aYFzXD0U--piuMq3y4XAmoYdawA2HC1cuEjM/

When the user deletes their browsing history in ClearBrowsingDataPreferences,
we might show them a dialog about other forms of browsing history. The dialog
is only shown once per profile (the shown state is stored in SharedPreferences)
and is only shown to users for which the web history service finds that it
is relevant. The web history service will have to make an asynchronous
request to find this out, and will inform us by calling
enableDialogAboutOtherFormsOfBrowsingHistory().

The web history service request and asynchronous callback is to be done
in a follow-up CL.

BUG=595332
Committed: https://crrev.com/b11f49b725456660d78267f78e4b10103c1ba20d
Cr-Commit-Position: refs/heads/master@{#386050}

[msramek, 2016-04-06 16:54:53]

Description was changed from

==========
Add a one-time notice about other forms of browsing history.

Design doc:
https://docs.google.com/document/d/1ZMDSAd44KmzKhqXPjobZOf9rZezs6VqiBnqpDD0auCU/

Mocks:
https://docs.google.com/presentation/d/1rpR3xB3aYFzXD0U--piuMq3y4XAmoYdawA2HC...

When the user deletes their browsing history in ClearBrowsingDataPreferences,
we might show them a dialog about other forms of browsing history. The dialog
is only shown once per profile (the shown state is stored in SharedPreferences)
and is only shown to users for which the web history service finds that it
is relevant. The web history service will have to make an asynchronous
request to find this out, and will inform us by calling
enableDialogAboutOtherFormsOfBrowsingHistory().

BUG=595332
==========

to

==========
Add a one-time notice about other forms of browsing history.

Design doc:
https://docs.google.com/document/d/1ZMDSAd44KmzKhqXPjobZOf9rZezs6VqiBnqpDD0auCU/

Mocks:
https://docs.google.com/presentation/d/1rpR3xB3aYFzXD0U--piuMq3y4XAmoYdawA2HC...

When the user deletes their browsing history in ClearBrowsingDataPreferences,
we might show them a dialog about other forms of browsing history. The dialog
is only shown once per profile (the shown state is stored in SharedPreferences)
and is only shown to users for which the web history service finds that it
is relevant. The web history service will have to make an asynchronous
request to find this out, and will inform us by calling
enableDialogAboutOtherFormsOfBrowsingHistory().

The web history service request and asynchronous callback is to be done
in a follow-up CL.

BUG=595332
==========

[msramek, 2016-04-06 17:19:08]

Patchset #1 (id:1) has been deleted

[msramek, 2016-04-06 17:19:15]

Patchset #1 (id:20001) has been deleted

[msramek, 2016-04-06 17:24:22]

msramek@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[msramek, 2016-04-06 17:24:23]

Hi Dan,

can you please have a look?

I normally send these reviews to newt@, but he's not taking new reviews... we
don't have separate owners for preferences/privacy, so I had to go all the way
up to chrome/android/OWNERS.

Thanks,
Martin

[gone, 2016-04-07 21:05:27]

Didn't see anything egregious here... lgtm % my comments to avoid another world
rotation on the review.

https://chromiumcodereview.appspot.com/1859373002/diff/40001/chrome/android/j...
File chrome/android/java/res/layout/other_forms_of_history_dialog.xml (right):

https://chromiumcodereview.appspot.com/1859373002/diff/40001/chrome/android/j...
chrome/android/java/res/layout/other_forms_of_history_dialog.xml:11:
style="@style/AlertDialogContent">
nit: add a space between " and >

https://chromiumcodereview.appspot.com/1859373002/diff/40001/chrome/android/j...
chrome/android/java/res/layout/other_forms_of_history_dialog.xml:13: <TextView
These should be indented by 4.  Looks weird, but that's how we do it in the
other XML files for some reason.

https://chromiumcodereview.appspot.com/1859373002/diff/40001/chrome/android/j...
chrome/android/java/res/layout/other_forms_of_history_dialog.xml:18:
android:textAppearance="?android:attr/textAppearanceMedium"
Should explicitly specify the font size and color instead of using
android:textAppearance; newt@ pointed out that this is unpredictable between
Holo and Material.

https://chromiumcodereview.appspot.com/1859373002/diff/60001/chrome/android/j...
File chrome/android/java/res/layout/other_forms_of_history_dialog.xml (right):

https://chromiumcodereview.appspot.com/1859373002/diff/60001/chrome/android/j...
chrome/android/java/res/layout/other_forms_of_history_dialog.xml:13: <TextView
Why is your text split into two?  It's all for one big blob of text that's
styled the same way, and it makes the string translation that much more
confusing.  Add a newline and make it a single string.

https://chromiumcodereview.appspot.com/1859373002/diff/60001/chrome/android/j...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferences.java
(right):

https://chromiumcodereview.appspot.com/1859373002/diff/60001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferences.java:278:
private boolean mDialogAboutOtherFormsOfBrowsingHistoryEnabled;
Group these new member fields with the other ones above all of the class methods
and below the static inner classes.  Doesn't make sense to have these randomly
located in the middle of a class where they would be missed during
initialization.

https://chromiumcodereview.appspot.com/1859373002/diff/60001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferences.java:481:
public void enableDialogAboutOtherFormsOfBrowsingHistory() {
...BrowsingHistoryForTests() to make it explicit.

https://chromiumcodereview.appspot.com/1859373002/diff/60001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferences.java:482:
mDialogAboutOtherFormsOfBrowsingHistoryEnabled = true;
mIsDialogAboutOtherFormsOfBrowsingHistoryEnabled?

https://chromiumcodereview.appspot.com/1859373002/diff/60001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferences.java:489:
OtherFormsOfHistoryDialogFragment getDialogAboutOtherFormsOfBrowsingHistory() {
...BrowsingHistoryForTests()

https://chromiumcodereview.appspot.com/1859373002/diff/60001/chrome/android/j...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/OtherFormsOfHistoryDialogFragment.java
(right):

https://chromiumcodereview.appspot.com/1859373002/diff/60001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/OtherFormsOfHistoryDialogFragment.java:36:
"clear_browsing_data_history_dialog_shown";
Prefix this with the package name, and make the string match the UPPERCASED bit.
 We've got a lot of similarly named preferences nowadays, so being overly
specific is preferable.

https://chromiumcodereview.appspot.com/1859373002/diff/60001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/OtherFormsOfHistoryDialogFragment.java:39:
private static final String URL_MY_ACTIVITY =
Can you think of a different way to name this?  In addition to the "User's
activities", "Activity" has a very specific meaning on Android.

https://chromiumcodereview.appspot.com/1859373002/diff/60001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/OtherFormsOfHistoryDialogFragment.java:94:
private static void setShown(Activity activity, boolean shown) {
recordDialogWasShown()?  setShown sounds like a mutator.

https://chromiumcodereview.appspot.com/1859373002/diff/60001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/OtherFormsOfHistoryDialogFragment.java:105:
public static boolean wasDialogShown(Context context) {
package protected?

https://chromiumcodereview.appspot.com/1859373002/diff/60001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/OtherFormsOfHistoryDialogFragment.java:113:
public static OtherFormsOfHistoryDialogFragment show(Activity activity) {
nit: Put this at the top of the class to make it more obvious that this is how
you're supposed to be creating this class, then make it package protected.

If you're not meant to be able to create this with a new
OtherFormsOfHistoryDialogFragment() from outside of this class, make the
constructor private, as well.

https://chromiumcodereview.appspot.com/1859373002/diff/60001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/OtherFormsOfHistoryDialogFragment.java:125:
public static void clearShownPreferenceForTesting(Activity activity) {
Possible to package protect?

https://chromiumcodereview.appspot.com/1859373002/diff/60001/chrome/android/j...
File chrome/android/java/strings/android_chrome_strings.grd (right):

https://chromiumcodereview.appspot.com/1859373002/diff/60001/chrome/android/j...
chrome/android/java/strings/android_chrome_strings.grd:440: OK, got it
Make this a common string at the top underneath IDS_OK.  There's a bunch of
features that keep using this colloquial string (I've got to add one by
tomorrow, e.g.), but we keep adding new copies of it.

https://chromiumcodereview.appspot.com/1859373002/diff/60001/chrome/android/j...
File
chrome/android/javatests/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferencesTest.java
(right):

https://chromiumcodereview.appspot.com/1859373002/diff/60001/chrome/android/j...
chrome/android/javatests/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferencesTest.java:321:
static class OpenPreferencesEnableDialogAndClickClearRunnable implements
Runnable {
Javadocs for classes and non-@Overriden public functions everywhere.

https://chromiumcodereview.appspot.com/1859373002/diff/60001/chrome/android/j...
chrome/android/javatests/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferencesTest.java:348:
super();
Shouldn't need to call super() in these these two cases.

https://chromiumcodereview.appspot.com/1859373002/diff/60001/chrome/android/j...
chrome/android/javatests/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferencesTest.java:376:

nit: remove newline to be consistent with preferences3

https://chromiumcodereview.appspot.com/1859373002/diff/60001/chrome/android/j...
chrome/android/javatests/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferencesTest.java:388:

nit: ditto

https://chromiumcodereview.appspot.com/1859373002/diff/60001/chrome/android/j...
chrome/android/javatests/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferencesTest.java:415:
// That should the preference screen as well.
should close?

[msramek, 2016-04-08 11:20:43]

Thanks a lot, Dan! Especially for being mindful about the time zone delays and
my need to land the string before branchpoint :)

I addressed your comments and I'm landing the CL now.

https://codereview.chromium.org/1859373002/diff/60001/chrome/android/java/res...
File chrome/android/java/res/layout/other_forms_of_history_dialog.xml (right):

https://codereview.chromium.org/1859373002/diff/60001/chrome/android/java/res...
chrome/android/java/res/layout/other_forms_of_history_dialog.xml:13: <TextView
On 2016/04/07 21:05:26, dfalcantara wrote:
> Why is your text split into two?  It's all for one big blob of text that's
> styled the same way, and it makes the string translation that much more
> confusing.  Add a newline and make it a single string.

Done.

https://codereview.chromium.org/1859373002/diff/60001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferences.java
(right):

https://codereview.chromium.org/1859373002/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferences.java:278:
private boolean mDialogAboutOtherFormsOfBrowsingHistoryEnabled;
On 2016/04/07 21:05:26, dfalcantara wrote:
> Group these new member fields with the other ones above all of the class
methods
> and below the static inner classes.  Doesn't make sense to have these randomly
> located in the middle of a class where they would be missed during
> initialization.

Done.

https://codereview.chromium.org/1859373002/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferences.java:481:
public void enableDialogAboutOtherFormsOfBrowsingHistory() {
On 2016/04/07 21:05:26, dfalcantara wrote:
> ...BrowsingHistoryForTests() to make it explicit.

They are currently used only in tests, because there is no connection to the
backend, but this method will be called from the backend in the followup CL.

https://codereview.chromium.org/1859373002/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferences.java:482:
mDialogAboutOtherFormsOfBrowsingHistoryEnabled = true;
On 2016/04/07 21:05:26, dfalcantara wrote:
> mIsDialogAboutOtherFormsOfBrowsingHistoryEnabled?

Done.

https://codereview.chromium.org/1859373002/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferences.java:489:
OtherFormsOfHistoryDialogFragment getDialogAboutOtherFormsOfBrowsingHistory() {
On 2016/04/07 21:05:26, dfalcantara wrote:
> ...BrowsingHistoryForTests()

Ditto as above.

https://codereview.chromium.org/1859373002/diff/60001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/OtherFormsOfHistoryDialogFragment.java
(right):

https://codereview.chromium.org/1859373002/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/OtherFormsOfHistoryDialogFragment.java:36:
"clear_browsing_data_history_dialog_shown";
On 2016/04/07 21:05:26, dfalcantara wrote:
> Prefix this with the package name, and make the string match the UPPERCASED
bit.
>  We've got a lot of similarly named preferences nowadays, so being overly
> specific is preferable.

Done.

https://codereview.chromium.org/1859373002/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/OtherFormsOfHistoryDialogFragment.java:39:
private static final String URL_MY_ACTIVITY =
On 2016/04/07 21:05:27, dfalcantara wrote:
> Can you think of a different way to name this?  In addition to the "User's
> activities", "Activity" has a very specific meaning on Android.

Done. Renamed here and in ClearBrowsingDataPreferences as well.

https://codereview.chromium.org/1859373002/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/OtherFormsOfHistoryDialogFragment.java:94:
private static void setShown(Activity activity, boolean shown) {
On 2016/04/07 21:05:27, dfalcantara wrote:
> recordDialogWasShown()?  setShown sounds like a mutator.

Done.

https://codereview.chromium.org/1859373002/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/OtherFormsOfHistoryDialogFragment.java:105:
public static boolean wasDialogShown(Context context) {
On 2016/04/07 21:05:27, dfalcantara wrote:
> package protected?

Done.

https://codereview.chromium.org/1859373002/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/OtherFormsOfHistoryDialogFragment.java:113:
public static OtherFormsOfHistoryDialogFragment show(Activity activity) {
On 2016/04/07 21:05:27, dfalcantara wrote:
> nit: Put this at the top of the class to make it more obvious that this is how
> you're supposed to be creating this class, then make it package protected.
> 
> If you're not meant to be able to create this with a new
> OtherFormsOfHistoryDialogFragment() from outside of this class, make the
> constructor private, as well.

Makes sense. Done.

https://codereview.chromium.org/1859373002/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/OtherFormsOfHistoryDialogFragment.java:125:
public static void clearShownPreferenceForTesting(Activity activity) {
On 2016/04/07 21:05:26, dfalcantara wrote:
> Possible to package protect?

Done. Yes, the test is in this package.

https://codereview.chromium.org/1859373002/diff/60001/chrome/android/java/str...
File chrome/android/java/strings/android_chrome_strings.grd (right):

https://codereview.chromium.org/1859373002/diff/60001/chrome/android/java/str...
chrome/android/java/strings/android_chrome_strings.grd:440: OK, got it
On 2016/04/07 21:05:27, dfalcantara wrote:
> Make this a common string at the top underneath IDS_OK.  There's a bunch of
> features that keep using this colloquial string (I've got to add one by
> tomorrow, e.g.), but we keep adding new copies of it.

Done. Yes, I was a bit surprised that it's not a common string. But strings get
deduplicated before they are sent to the translation, so at least there is no
inconsistency / translation workload problem, just code size.

https://codereview.chromium.org/1859373002/diff/60001/chrome/android/javatest...
File
chrome/android/javatests/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferencesTest.java
(right):

https://codereview.chromium.org/1859373002/diff/60001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferencesTest.java:321:
static class OpenPreferencesEnableDialogAndClickClearRunnable implements
Runnable {
On 2016/04/07 21:05:27, dfalcantara wrote:
> Javadocs for classes and non-@Overriden public functions everywhere.

Done.

https://codereview.chromium.org/1859373002/diff/60001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferencesTest.java:348:
super();
On 2016/04/07 21:05:27, dfalcantara wrote:
> Shouldn't need to call super() in these these two cases.

Done.

https://codereview.chromium.org/1859373002/diff/60001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferencesTest.java:376:

On 2016/04/07 21:05:27, dfalcantara wrote:
> nit: remove newline to be consistent with preferences3 

Done.

https://codereview.chromium.org/1859373002/diff/60001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferencesTest.java:388:

On 2016/04/07 21:05:27, dfalcantara wrote:
> nit: ditto

Done.

https://codereview.chromium.org/1859373002/diff/60001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferencesTest.java:415:
// That should the preference screen as well.
On 2016/04/07 21:05:27, dfalcantara wrote:
> should close?

Done.

[msramek, 2016-04-08 11:32:22]

The CQ bit was checked by msramek@chromium.org

[msramek, 2016-04-08 11:32:23]

The patchset sent to the CQ was uploaded after l-g-t-m from
dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/1859373002/#ps100001
(title: "Rebase")

[commit-bot: I haz the power, 2016-04-08 11:32:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1859373002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1859373002/100001

[commit-bot: I haz the power, 2016-04-08 12:08:58]

Description was changed from

==========
Add a one-time notice about other forms of browsing history.

Design doc:
https://docs.google.com/document/d/1ZMDSAd44KmzKhqXPjobZOf9rZezs6VqiBnqpDD0auCU/

Mocks:
https://docs.google.com/presentation/d/1rpR3xB3aYFzXD0U--piuMq3y4XAmoYdawA2HC...

When the user deletes their browsing history in ClearBrowsingDataPreferences,
we might show them a dialog about other forms of browsing history. The dialog
is only shown once per profile (the shown state is stored in SharedPreferences)
and is only shown to users for which the web history service finds that it
is relevant. The web history service will have to make an asynchronous
request to find this out, and will inform us by calling
enableDialogAboutOtherFormsOfBrowsingHistory().

The web history service request and asynchronous callback is to be done
in a follow-up CL.

BUG=595332
==========

to

==========
Add a one-time notice about other forms of browsing history.

Design doc:
https://docs.google.com/document/d/1ZMDSAd44KmzKhqXPjobZOf9rZezs6VqiBnqpDD0auCU/

Mocks:
https://docs.google.com/presentation/d/1rpR3xB3aYFzXD0U--piuMq3y4XAmoYdawA2HC...

When the user deletes their browsing history in ClearBrowsingDataPreferences,
we might show them a dialog about other forms of browsing history. The dialog
is only shown once per profile (the shown state is stored in SharedPreferences)
and is only shown to users for which the web history service finds that it
is relevant. The web history service will have to make an asynchronous
request to find this out, and will inform us by calling
enableDialogAboutOtherFormsOfBrowsingHistory().

The web history service request and asynchronous callback is to be done
in a follow-up CL.

BUG=595332
==========

[commit-bot: I haz the power, 2016-04-08 12:08:59]

Committed patchset #4 (id:100001)

[commit-bot: I haz the power, 2016-04-08 12:09:50]

Description was changed from

==========
Add a one-time notice about other forms of browsing history.

Design doc:
https://docs.google.com/document/d/1ZMDSAd44KmzKhqXPjobZOf9rZezs6VqiBnqpDD0auCU/

Mocks:
https://docs.google.com/presentation/d/1rpR3xB3aYFzXD0U--piuMq3y4XAmoYdawA2HC...

When the user deletes their browsing history in ClearBrowsingDataPreferences,
we might show them a dialog about other forms of browsing history. The dialog
is only shown once per profile (the shown state is stored in SharedPreferences)
and is only shown to users for which the web history service finds that it
is relevant. The web history service will have to make an asynchronous
request to find this out, and will inform us by calling
enableDialogAboutOtherFormsOfBrowsingHistory().

The web history service request and asynchronous callback is to be done
in a follow-up CL.

BUG=595332
==========

to

==========
Add a one-time notice about other forms of browsing history.

Design doc:
https://docs.google.com/document/d/1ZMDSAd44KmzKhqXPjobZOf9rZezs6VqiBnqpDD0auCU/

Mocks:
https://docs.google.com/presentation/d/1rpR3xB3aYFzXD0U--piuMq3y4XAmoYdawA2HC...

When the user deletes their browsing history in ClearBrowsingDataPreferences,
we might show them a dialog about other forms of browsing history. The dialog
is only shown once per profile (the shown state is stored in SharedPreferences)
and is only shown to users for which the web history service finds that it
is relevant. The web history service will have to make an asynchronous
request to find this out, and will inform us by calling
enableDialogAboutOtherFormsOfBrowsingHistory().

The web history service request and asynchronous callback is to be done
in a follow-up CL.

BUG=595332

Committed: https://crrev.com/b11f49b725456660d78267f78e4b10103c1ba20d
Cr-Commit-Position: refs/heads/master@{#386050}
==========

[commit-bot: I haz the power, 2016-04-08 12:09:51]

Patchset 4 (id:??) landed as
https://crrev.com/b11f49b725456660d78267f78e4b10103c1ba20d
Cr-Commit-Position: refs/heads/master@{#386050}

[gone, 2016-04-08 17:16:34]

If you could follow up and move the variables, that'd be great.

https://chromiumcodereview.appspot.com/1859373002/diff/100001/chrome/android/...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferences.java
(right):

https://chromiumcodereview.appspot.com/1859373002/diff/100001/chrome/android/...
chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferences.java:135:
private boolean mIsDialogAboutOtherFormsOfBrowsingHistoryEnabled;
Meant for these to get grouped with mProgressDialog and mItems below.  Clearly
they weren't easy enough to find :/

[msramek, 2016-04-08 17:32:50]

https://chromiumcodereview.appspot.com/1859373002/diff/100001/chrome/android/...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferences.java
(right):

https://chromiumcodereview.appspot.com/1859373002/diff/100001/chrome/android/...
chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferences.java:135:
private boolean mIsDialogAboutOtherFormsOfBrowsingHistoryEnabled;
On 2016/04/08 17:16:33, dfalcantara wrote:
> Meant for these to get grouped with mProgressDialog and mItems below.  Clearly
> they weren't easy enough to find :/

Ah, right. Non-static under static. Will do right away.

[gone, 2016-04-08 17:33:49]

On 2016/04/08 17:32:50, msramek wrote:
>
https://chromiumcodereview.appspot.com/1859373002/diff/100001/chrome/android/...
> File
>
chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferences.java
> (right):
> 
>
https://chromiumcodereview.appspot.com/1859373002/diff/100001/chrome/android/...
>
chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferences.java:135:
> private boolean mIsDialogAboutOtherFormsOfBrowsingHistoryEnabled;
> On 2016/04/08 17:16:33, dfalcantara wrote:
> > Meant for these to get grouped with mProgressDialog and mItems below. 
Clearly
> > they weren't easy enough to find :/
> 
> Ah, right. Non-static under static. Will do right away.

I think you'd be fine if you just group it with 1870703002; I'm reviewing that
now.