Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 1875633003: Move the nonstatic members under static ones in ClearBrowsingDataPreferences (Closed)

Created:
4 years, 8 months ago by msramek
Modified:
4 years, 8 months ago
Reviewers:
gone
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@add-dialog-rebased
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move the nonstatic members under static ones in ClearBrowsingDataPreferences This is a followup to https://chromiumcodereview.appspot.com/1859373002/. BUG=595332 Committed: https://crrev.com/9148ef94084fbfb94f5ef9404e7326059cc2d548 Cr-Commit-Position: refs/heads/master@{#386137}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferences.java View 2 chunks +3 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (5 generated)
msramek
Hi Dan, here's the promised followup. PTAL! Thanks, Martin
4 years, 8 months ago (2016-04-08 17:33:57 UTC) #3
gone
lgtm, thanks
4 years, 8 months ago (2016-04-08 17:35:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1875633003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1875633003/1
4 years, 8 months ago (2016-04-08 18:33:12 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-08 18:42:01 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-08 18:43:13 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9148ef94084fbfb94f5ef9404e7326059cc2d548
Cr-Commit-Position: refs/heads/master@{#386137}

Powered by Google App Engine
This is Rietveld 408576698