Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Unified Diff: third_party/WebKit/Source/core/inspector/MainThreadDebugger.h

Issue 1859293002: [DevTools] Move Console to v8_inspector (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/MainThreadDebugger.h
diff --git a/third_party/WebKit/Source/core/inspector/MainThreadDebugger.h b/third_party/WebKit/Source/core/inspector/MainThreadDebugger.h
index 000c6b6e58e3a8a959f159d71c2e663feb300d5c..702c8566d2029fdf5c98df216738c42ef0d5e8b5 100644
--- a/third_party/WebKit/Source/core/inspector/MainThreadDebugger.h
+++ b/third_party/WebKit/Source/core/inspector/MainThreadDebugger.h
@@ -68,6 +68,11 @@ public:
void contextCreated(ScriptState*, LocalFrame*, SecurityOrigin*);
void contextWillBeDestroyed(ScriptState*);
+ bool hasMemoryOnConsole(v8::Local<v8::Context>) override;
dgozman 2016/04/08 18:18:46 This bit should be a part of V8ContextInfo, which
kozy 2016/04/08 23:56:50 Done.
+ v8::MaybeLocal<v8::Value> memoryInfo(v8::Isolate*, v8::Local<v8::Context>, v8::Local<v8::Object> creationContext) override;
dgozman 2016/04/08 18:18:46 We can probably do this directly by asking V8.
kozy 2016/04/08 23:56:50 blink implementation is using a lot of core relate
+protected:
+ void reportMessageToConsole(v8::Local<v8::Context>, ConsoleMessage*);
dgozman 2016/04/08 18:18:46 override?
kozy 2016/04/08 23:56:50 Done.
+
private:
// V8DebuggerClient implementation.
void runMessageLoopOnPause(int contextGroupId) override;

Powered by Google App Engine
This is Rietveld 408576698