Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(529)

Unified Diff: third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp

Issue 1859293002: [DevTools] Move Console to v8_inspector (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebased Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp
diff --git a/third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp b/third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp
index e2681cea7cfbd41d44761944e072498eaa8b0bf9..e6cd4e616eb2166bbdfd6e5349a3344eea2ae2d1 100644
--- a/third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp
+++ b/third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp
@@ -4,6 +4,8 @@
#include "core/inspector/ThreadDebugger.h"
+#include "bindings/core/v8/ScriptCallStack.h"
+#include "bindings/core/v8/ScriptValue.h"
#include "bindings/core/v8/V8Binding.h"
#include "bindings/core/v8/V8DOMException.h"
#include "bindings/core/v8/V8DOMTokenList.h"
@@ -11,7 +13,10 @@
#include "bindings/core/v8/V8HTMLCollection.h"
#include "bindings/core/v8/V8Node.h"
#include "bindings/core/v8/V8NodeList.h"
+#include "core/inspector/ConsoleMessage.h"
#include "core/inspector/InspectorDOMDebuggerAgent.h"
+#include "core/inspector/InspectorTraceEvents.h"
+#include "core/inspector/ScriptArguments.h"
#include "platform/ScriptForbiddenScope.h"
#include "wtf/CurrentTime.h"
@@ -62,5 +67,42 @@ double ThreadDebugger::currentTimeMS()
return WTF::currentTimeMS();
}
+void ThreadDebugger::reportMessageToConsole(v8::Local<v8::Context> context, MessageType type, MessageLevel level, const String16& message, const v8::FunctionCallbackInfo<v8::Value>* arguments, unsigned skipArgumentCount, int maxStackSize)
+{
+ ScriptState* scriptState = ScriptState::from(context);
+ ScriptArguments* scriptArguments = nullptr;
+ if (arguments && scriptState->contextIsValid())
+ scriptArguments = ScriptArguments::create(scriptState, *arguments, skipArgumentCount);
+ String messageText = message;
+ if (messageText.isEmpty() && scriptArguments)
+ scriptArguments->getFirstArgumentAsString(messageText);
+
+ ConsoleMessage* consoleMessage = ConsoleMessage::create(ConsoleAPIMessageSource, level, messageText);
+ consoleMessage->setType(type);
+ consoleMessage->setScriptState(scriptState);
+ if (arguments)
+ consoleMessage->setScriptArguments(scriptArguments);
+ if (maxStackSize == -1)
+ consoleMessage->setCallStack(ScriptCallStack::captureForConsole());
+ else if (maxStackSize)
+ consoleMessage->setCallStack(ScriptCallStack::capture(maxStackSize));
+ reportMessageToConsole(context, consoleMessage);
+}
+
+void ThreadDebugger::consoleTime(const String16& title)
+{
+ TRACE_EVENT_COPY_ASYNC_BEGIN0("blink.console", String(title).utf8().data(), this);
+}
+
+void ThreadDebugger::consoleTimeEnd(const String16& title)
+{
+ TRACE_EVENT_COPY_ASYNC_END0("blink.console", String(title).utf8().data(), this);
+}
+
+void ThreadDebugger::consoleTimeStamp(const String16& title)
+{
+ v8::Isolate* isolate = m_isolate;
+ TRACE_EVENT_INSTANT1("devtools.timeline", "TimeStamp", TRACE_EVENT_SCOPE_THREAD, "data", InspectorTimeStampEvent::data(currentExecutionContext(isolate), title));
+}
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698