Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1274)

Issue 1858773004: Revert of Correctly annotate eval origin. (Closed)

Created:
4 years, 8 months ago by Michael Achenbach
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com, v8-x87-ports_googlegroups.com, oth, rmcilroy, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Correctly annotate eval origin. (patchset #4 id:60001 of https://codereview.chromium.org/1854713002/ ) Reason for revert: [Sheriff] Crashes a layout test: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/5855 Original issue's description: > Correctly annotate eval origin. > > There were a couple of issues with it: > - interpreter is not supported > - the source position was just accidentally correct for full-codegen > - the eval origin could have been cached > > Also fixes a few other places to use AbstractCode. > > R=mstarzinger@chromium.org > > Committed: https://crrev.com/2f3a171adc9e620c2235bf0562145b9d4eaba66d > Cr-Commit-Position: refs/heads/master@{#35257} TBR=mstarzinger@chromium.org,yangguo@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/cf951dfb372816fde47bd050d9fa7d1889f38d76 Cr-Commit-Position: refs/heads/master@{#35260}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+265 lines, -176 lines) Patch
M src/accessors.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M src/api.cc View 2 chunks +5 lines, -7 lines 0 comments Download
M src/builtins.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M src/compiler.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler.cc View 5 chunks +6 lines, -9 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/debug/debug.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/debug/debug.cc View 8 chunks +27 lines, -6 lines 0 comments Download
M src/debug/debug-evaluate.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M src/debug/debug-frames.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/debug/liveedit.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/frames.h View 2 chunks +2 lines, -5 lines 0 comments Download
M src/frames.cc View 2 chunks +5 lines, -11 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M src/full-codegen/full-codegen.h View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M src/full-codegen/s390/full-codegen-s390.cc View 4 chunks +5 lines, -6 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M src/heap/heap.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/interpreter/bytecode-generator.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/isolate.cc View 1 chunk +3 lines, -10 lines 0 comments Download
M src/objects.h View 2 chunks +5 lines, -5 lines 0 comments Download
M src/objects-inl.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/objects-printer.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/runtime/runtime-compiler.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/CallLookupSlot.golden View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/Eval.golden View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/IfConditions.golden View 1 chunk +116 lines, -0 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/LookupSlot.golden View 3 chunks +3 lines, -3 lines 0 comments Download
D test/mjsunit/eval-origin.js View 1 chunk +0 lines, -37 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Achenbach
Created Revert of Correctly annotate eval origin.
4 years, 8 months ago (2016-04-05 13:00:27 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1858773004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1858773004/1
4 years, 8 months ago (2016-04-05 13:00:38 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-05 13:00:57 UTC) #4
commit-bot: I haz the power
4 years, 8 months ago (2016-04-05 13:01:26 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cf951dfb372816fde47bd050d9fa7d1889f38d76
Cr-Commit-Position: refs/heads/master@{#35260}

Powered by Google App Engine
This is Rietveld 408576698