src/interpreter/bytecode-generator.cc - Issue 1858773004: Revert of Correctly annotate eval origin.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/interpreter/bytecode-generator.cc

Issue 1858773004: Revert of Correctly annotate eval origin. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/interpreter/bytecode-generator.cc

diff --git a/src/interpreter/bytecode-generator.cc b/src/interpreter/bytecode-generator.cc

index 069307e3a8ad76ad9ae46e4a0aaf174b1b7f99e9..799202deb8d94145c67b34194d3de2181e2907a9 100644

--- a/src/interpreter/bytecode-generator.cc

+++ b/src/interpreter/bytecode-generator.cc

@@ -2468,7 +2468,8 @@

.MoveRegister(Register::function_closure(), function)

.LoadLiteral(Smi::FromInt(language_mode()))

.StoreAccumulatorInRegister(language)

- .LoadLiteral(Smi::FromInt(expr->position()))

+ .LoadLiteral(

+ Smi::FromInt(execution_context()->scope()->start_position()))

.StoreAccumulatorInRegister(position);

// Call ResolvePossiblyDirectEval and modify the callee.

« no previous file with comments | « src/heap/heap.cc ('k') | src/isolate.cc » ('j') | no next file with comments »